From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935667AbcHBRFM (ORCPT ); Tue, 2 Aug 2016 13:05:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:10715 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932851AbcHBMAA (ORCPT ); Tue, 2 Aug 2016 08:00:00 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1033580240" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, maintainers@bluecherrydvr.com, andrey.utkin@corp.bluecherry.net, ismael@iodev.co.uk, bp@alien8.de Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, nenggun.kim@samsung.com, hdegoede@redhat.com Subject: [PATCH 0510/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:19:25 +0800 Message-Id: <20160802111925.15959-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/pci/ttpci/budget-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/ttpci/budget-core.c b/drivers/media/pci/ttpci/budget-core.c index 6d42dcf..6a0b98b 100644 --- a/drivers/media/pci/ttpci/budget-core.c +++ b/drivers/media/pci/ttpci/budget-core.c @@ -52,8 +52,8 @@ int budget_debug; static int dma_buffer_size = TS_MIN_BUFSIZE_K; -module_param_named(debug, budget_debug, int, 0644); -module_param_named(bufsize, dma_buffer_size, int, 0444); +module_param_named(debug, budget_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); +module_param_named(bufsize, dma_buffer_size, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "Turn on/off budget debugging (default:off)."); MODULE_PARM_DESC(bufsize, "DMA buffer size in KB, default: 188, min: 188, max: 1410 (Activy: 564)"); -- 2.9.2