From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030226AbcHBQ1n (ORCPT ); Tue, 2 Aug 2016 12:27:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:32858 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934038AbcHBML7 (ORCPT ); Tue, 2 Aug 2016 08:11:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743080098" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, mkrufky@linuxtv.org, s.nawrocki@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr, hans.verkuil@cisco.com, loepke@edfritsch.de, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0614/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:30:03 +0800 Message-Id: <20160802113003.22982-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/media/usb/dvb-usb/technisat-usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c b/drivers/media/usb/dvb-usb/technisat-usb2.c index d9f3262..f53a861 100644 --- a/drivers/media/usb/dvb-usb/technisat-usb2.c +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c @@ -40,7 +40,7 @@ DVB_DEFINE_MOD_OPT_ADAPTER_NR(adapter_nr); static int debug; -module_param(debug, int, 0644); +module_param(debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "set debugging level (bit-mask: 1=info,2=eeprom,4=i2c,8=rc)." \ DVB_USB_DEBUG_STATUS); @@ -48,7 +48,7 @@ MODULE_PARM_DESC(debug, /* disables all LED control command and * also does not start the signal polling thread */ static int disable_led_control; -module_param(disable_led_control, int, 0444); +module_param(disable_led_control, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(disable_led_control, "disable LED control of the device " "(default: 0 - LED control is active)."); -- 2.9.2