From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934451AbcHBQDX (ORCPT ); Tue, 2 Aug 2016 12:03:23 -0400 Received: from mga14.intel.com ([192.55.52.115]:20181 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934240AbcHBMSo (ORCPT ); Tue, 2 Aug 2016 08:18:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="1018213022" From: Baole Ni To: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, tglx@linutronix.de Subject: [PATCH 0671/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:35:30 +0800 Message-Id: <20160802113530.26797-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/memstick/core/memstick.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/memstick/core/memstick.c b/drivers/memstick/core/memstick.c index a0547db..4781223 100644 --- a/drivers/memstick/core/memstick.c +++ b/drivers/memstick/core/memstick.c @@ -22,7 +22,7 @@ #define DRIVER_NAME "memstick" static unsigned int cmd_retries = 3; -module_param(cmd_retries, uint, 0644); +module_param(cmd_retries, uint, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); static struct workqueue_struct *workqueue; static DEFINE_IDR(memstick_host_idr); -- 2.9.2