From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967395AbcHBP2I (ORCPT ); Tue, 2 Aug 2016 11:28:08 -0400 Received: from mga03.intel.com ([134.134.136.65]:27319 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934798AbcHBMc7 (ORCPT ); Tue, 2 Aug 2016 08:32:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743089084" From: Baole Ni To: a.zummo@towertech.it, alexandre.belloni@free-electrons.com, paulus@samba.org, mpe@ellerman.id.au, dwmw2@infradead.org, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0873/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 19:54:03 +0800 Message-Id: <20160802115403.8176-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/rtc/rtc-max8997.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c index db984d4..006c362 100644 --- a/drivers/rtc/rtc-max8997.c +++ b/drivers/rtc/rtc-max8997.c @@ -25,11 +25,11 @@ /* Module parameter for WTSR function control */ static int wtsr_en = 1; -module_param(wtsr_en, int, 0444); +module_param(wtsr_en, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(wtsr_en, "Watchdog Timeout & Software Reset (default=on)"); /* Module parameter for SMPL function control */ static int smpl_en = 1; -module_param(smpl_en, int, 0444); +module_param(smpl_en, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(smpl_en, "Sudden Momentary Power Loss (default=on)"); /* RTC Control Register */ -- 2.9.2