From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964927AbcHBMaO (ORCPT ); Tue, 2 Aug 2016 08:30:14 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:33031 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934699AbcHBM3A (ORCPT ); Tue, 2 Aug 2016 08:29:00 -0400 Date: Tue, 2 Aug 2016 05:28:08 -0700 From: Christoph Hellwig To: Eryu Guan Cc: linux-fsdevel@vger.kernel.org, open list , "supporter:XFS FILESYSTEM" , "open list:GFS2 FILE SYSTEM" , Alexander Viro , Bob Peterson , Steven Whitehouse Subject: Re: [PATCH v2 RESEND] fs: return EPERM on immutable inode Message-ID: <20160802122808.GF31492@infradead.org> References: <1470139108-13115-1-git-send-email-guaneryu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470139108-13115-1-git-send-email-guaneryu@gmail.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 07:58:28PM +0800, Eryu Guan wrote: > In most cases, EPERM is returned on immutable inode, and there're only a > few places returning EACCES. I noticed this when running LTP on > overlayfs, setxattr03 failed due to unexpected EACCES on immutable > inode. > > So converting all EACCES to EPERM on immutable inode. Looks fine, Reviewed-by: Christoph Hellwig Although maybe you'll have to split this into one patch per subsystems, as otherwise no maintainer might be enticed to pick it up.