From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967358AbcHBP0F (ORCPT ); Tue, 2 Aug 2016 11:26:05 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34445 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934853AbcHBMdB (ORCPT ); Tue, 2 Aug 2016 08:33:01 -0400 Date: Tue, 2 Aug 2016 15:32:42 +0300 From: Leon Romanovsky To: Baole Ni Cc: matanb@mellanox.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, bp@alien8.de, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, hch@infradead.org, markb@mellanox.com, jgunthorpe@obsidianresearch.com, dean.luick@intel.com Subject: Re: [PATCH 0261/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802123242.GB27667@leon.nu> References: <20160802105418.31139-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI" Content-Disposition: inline In-Reply-To: <20160802105418.31139-1-baolex.ni@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PmA2V3Z32TCmWXqI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 02, 2016 at 06:54:18PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permiss= ion. > As we know, these numeric value for access permission have had the corres= ponding macro, > and that using macro can improve the robustness and readability of the co= de, > thus, I suggest replacing the numeric parameter with the macro. >=20 > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- Thanks, Acked-by: Leon Romanovsky > drivers/infiniband/hw/mlx5/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/ml= x5/main.c > index b48ad85..3ae01dc 100644 > --- a/drivers/infiniband/hw/mlx5/main.c > +++ b/drivers/infiniband/hw/mlx5/main.c > @@ -65,7 +65,7 @@ MODULE_LICENSE("Dual BSD/GPL"); > MODULE_VERSION(DRIVER_VERSION); > =20 > static int deprecated_prof_sel =3D 2; > -module_param_named(prof_sel, deprecated_prof_sel, int, 0444); > +module_param_named(prof_sel, deprecated_prof_sel, int, S_IRUSR | S_IRGRP= | S_IROTH); > MODULE_PARM_DESC(prof_sel, "profile selector. Deprecated here. Moved to = module mlx5_core"); > =20 > static char mlx5_version[] =3D > --=20 > 2.9.2 >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --PmA2V3Z32TCmWXqI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXoJLpAAoJEORje4g2clinlqQQAJ84pjRm+RKlo9dSwpkasMPF +ByD63qVYfjHKI2Pe3DW0t72/suZkKf4DClsJmCpewKASZKywKopZ7zUCP5xcziS piQ06EH7XkoL3lOlGJzZwXVAjVzsK+6QfmZa/F2erNu8xiKLZO0azSZqN1/L8yJ0 0KmiQC08bc8CvN48kBwemLZcKdfG1lwor+lSmHQjFNvS2/Xtli8BGxOU6db5XMXB HM0CWphvoZBaWuQl8YdDxQ6TTbOhUsAkxuSZU3SCzi0uXjKcgcywa7lOWQ7yEAAB cZC4A4yZhEpu4OVxD9fbZBAT98Jp0i5gMhqcQ2EJhzUhvBlbZRGspIg1TJT38bzA GNF/NR26S7ZlVYpXOzDHyhQQ4MB58/GuEKknjDLPvf22NVKxGqIhEKTU6ovE8frE E3SF2dOjcSk17uq3E9fzPp4C6WTDB1e5B3fqO4kGh4atUBrmhCEITpJKsixRPFDE M3EC1Vj6mYTHcsB3Pd0GkTfVISqM8ucPxPa0N/492t7mWCsnoRx/dPx3gYE+A6fP hwFU6zsA1vUykwFXnkekCGfntih6WY17nAX/cgXUxgPYqIhn2slGg3xEbrp5iTq9 tqD/nP7hbn0Pth6YNfEgrJVl+ob2YjH8CJTvUvgVMO3VP5GojvlMXTi6hdHhO/vj gkuVAq0+zlrQYkbLNeA0 =2KNV -----END PGP SIGNATURE----- --PmA2V3Z32TCmWXqI--