From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967128AbcHBOBb (ORCPT ); Tue, 2 Aug 2016 10:01:31 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:58629 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966139AbcHBOAz (ORCPT ); Tue, 2 Aug 2016 10:00:55 -0400 X-IronPort-AV: E=Sophos;i="5.28,460,1464652800"; d="scan'208";a="376878551" Date: Tue, 2 Aug 2016 13:40:08 +0100 From: Wei Liu To: Baole Ni CC: , , , , , , , , , , , Subject: Re: [PATCH 0805/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802124008.GL22419@citrix.com> References: <20160802114812.3632-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160802114812.3632-1-baolex.ni@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 07:48:12PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Acked-by: Wei Liu