From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966463AbcHBNcX (ORCPT ); Tue, 2 Aug 2016 09:32:23 -0400 Received: from gate.crashing.org ([63.228.1.57]:33464 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966611AbcHBNal (ORCPT ); Tue, 2 Aug 2016 09:30:41 -0400 Date: Tue, 2 Aug 2016 07:41:18 -0500 From: Segher Boessenkool To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, stable@vger.kernel.org, antoine.blangy@c-s.fr Subject: Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic() Message-ID: <20160802124118.GA10155@gate.crashing.org> References: <20160802080705.69A9F1A2394@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802080705.69A9F1A2394@localhost.localdomain> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 10:07:05AM +0200, Christophe Leroy wrote: > commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() > based on copy_tofrom_user()") introduced a bug when destination > address is odd and initial csum is not null > > In that (rare) case the initial csum value has to be rotated one byte > as well as the resulting value is > > This patch also fixes related comments > > Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic() > based on copy_tofrom_user()") > Cc: stable@vger.kernel.org > > Signed-off-by: Christophe Leroy > --- > v2: updated comments as suggested by Segher Thanks. It looks good to me now. Segher