From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965304AbcHBOr6 (ORCPT ); Tue, 2 Aug 2016 10:47:58 -0400 Received: from mail-db5eur01on0090.outbound.protection.outlook.com ([104.47.2.90]:47184 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934970AbcHBMnB (ORCPT ); Tue, 2 Aug 2016 08:43:01 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; Date: Tue, 2 Aug 2016 15:42:20 +0300 From: Vladimir Davydov To: Michal Hocko CC: Andrew Morton , Johannes Weiner , , Subject: Re: [PATCH] radix-tree: account nodes to memcg only if explicitly requested Message-ID: <20160802124220.GC13263@esperanza> References: <1470057188-7864-1-git-send-email-vdavydov@virtuozzo.com> <20160802115111.GG12403@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160802115111.GG12403@dhcp22.suse.cz> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: HE1PR02CA0078.eurprd02.prod.outlook.com (10.163.170.46) To VI1PR0801MB1871.eurprd08.prod.outlook.com (10.173.73.21) X-MS-Office365-Filtering-Correlation-Id: a27eb2ac-52b6-42b9-461b-08d3bad27617 X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1871;2:mPTZAfcIzqgGViSkcYSLxk0mhRWbg7Rot/4IbzNxvv2Y60RHPSWgje+3cwtVA4ai14Ko1OjR5khqfxUU/HgBvjZ6oWrill0OtcELhsOtYUC3BOYw9a/cQYN+6QME1r38pfR1o2kyVPQW2cIy/VGOypZX4cn/X17+jhNUh6AJRQr2iWXrfL61MkrdA0QrmbPT;3:6LaiShhL9yNqFpCW9mnUe2poG3McTMIAhHtcLLNNC55Fw9DxQnFhZp8639BD0rLuPsvR60werP0jVUHjFemPo3OqtIhRmRlfatkGSBZjseGb7qy/jDHtcBFTKuYCgyli;25:iGdTbTAMVFXtW52NdkGJuUJTl/88PaeeMaisqEnCwkLYUlKRBT5JVnckmEwvK6VlBrqaVVvOiPtaW6uwtIDJdoo9VTsHnCsQktj9UX0JDgeIeA5tuw/CTX2g3m3duh9w6LnwHWg2Bi3beqEG8gSgozkegQKcCHGJ4GtOQGMPIOhHcVHhQFfNIrOJ874xCHjUmTABm1fzPcMVjq+ZW5+KE+fvM61HIMyS3s+adppb6cu0SLN39GsWO+s5pH2hFP2syPUKedBMiO0bhYi4kd+EIg7ijanQkUdD8orP2AqOLthK6Xb0dAUvUtvuabPdzw/G7MtZDuJaiXnA1A6HclUHV1NQvaC0MGF5UZMhOz7SlfObkbYbIhfmz8qS5y1YKgVZZSi7G8CyJImC+I76QQkg/UY7HMjjX3J90vR2+fPKtSg= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1871; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1871;31:y3DjN1mSHacx7xxwGjmu/YhgopOloSWi3cUVDsm/cPekrHfSr5Px+1McYzqldz73p9eNIBZVtjK6o69W06qRuajej9G6RjiHL4nKdNkfT9gm6Ue8VKYDj732+YCzPAzMTEv+D6xfFGl98/qYJdPjdeppXnhlrjllmWx9v/Ufy/OrgXmpj6uGSel+tCNOAVX305AJcb4AAbFy/i/d0QrNFzTisq0/OMWwy1WaPfq8yug=;4:Lj/oJvLympJTfTQwKsSBPMPgn3J6lbv2/aNZakLigQACREiO7vw6O0Ku6VuDMYOhwE8LzsWy6GDJysJqsQ6ll0aUAMgjOIUlr/PmGk2cHPJLP24XCQzxMAGHfa9FuzYpwDCxGjA5KMwBR4qAG3pL4FlTUuQgoIntZxQVA6YnP/+wHcDpcsv4wvP4ASbzYfGl65A7SCdJ3TsUgudLL/3wPeMbkAdo/J6Ah/O0jTfiUhhppW3Mef/xiBYE1IcFnxiOAGn16jW1ArmancrtXjoD77H3tL/TqMkxy0rqeGocw9TfDf+wiZEl1L5B3V4+QPP6MYW5oKGGEQVDam0q16N+Wa1QBZgBIEVzA8CCJi3XoRXBrPRA1sUCf2l9PpA2ZdMU5949JM8BI/tvQ3okEtVn8nkH88bxeofV2WevrYq/WKc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:VI1PR0801MB1871;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1871; X-Forefront-PRVS: 0022134A87 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(24454002)(377424004)(189002)(97756001)(76176999)(15650500001)(86362001)(9686002)(42186005)(101416001)(33716001)(54356999)(50986999)(106356001)(105586002)(46406003)(77096005)(23726003)(1076002)(68736007)(3846002)(305945005)(47776003)(586003)(92566002)(19580405001)(4326007)(2950100001)(7846002)(50466002)(33656002)(189998001)(2906002)(8676002)(97736004)(19580395003)(66066001)(81156014)(80792005)(110136002)(6116002)(81166006)(7736002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1871;H:esperanza;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR0801MB1871;23:NBGtai/HCDxSsU7aKoZsvmSd37wFXNpnNjKLoak?= =?us-ascii?Q?Tm2P92wBz1BTUBDmdAuLPlUxAksXLJVfoaIhhliFp16KWv4lViF/o3uID8yu?= =?us-ascii?Q?Wpy87F7GHD0waeQO47UIf28McbbVmwy+nKwzT03LUm2Na2OI97LI41IWMu56?= =?us-ascii?Q?7oj5DpqPJGIuwu0boP1u/BBq+VeLQJPv2g+A89oULS1qyWHbqt6B8QB7hCw5?= =?us-ascii?Q?n/YNxV8dP2BUOFjg6K67G8JEhwC+gRdeyHIT6GjaOdyZKm/jsVYo4IypjSO4?= =?us-ascii?Q?p5Q5LcQKQTEWsYD1/IuAsAjwwIlB5Q/I+wKCI5LITlruTUwj/NFW4l/U5D5P?= =?us-ascii?Q?uDRmW7lmqyPgN4Xv2CKcw62Y7DYvArXD6/oVmS8zPNeNywTVTpAKpTDlyd3r?= =?us-ascii?Q?G5KAM5jec/tD34MXy8RpE4D8kX9W6i7dzmKgDGVXP7ggxUjTYneqNJAjw6b6?= =?us-ascii?Q?uLic6cpEgbrQGk6ry3IT9nt7ugSMd5xKFmW5v0U5Z28DxeW4h06/nnDStUvN?= =?us-ascii?Q?VsF1YdaeO+b4b2RDDWIz8yVlnpKBE3BxFahLxpXYnPv3iqmpLmB0EkZDX159?= =?us-ascii?Q?XslPUjXKGr5IyLpeHTIuhnd5FHBw/F32dJWGGD/9qy937Iy9ajXDn0hZjwXU?= =?us-ascii?Q?rvktvVnHBY7vjIkb0kfyO5nZs0mAkQpM5DHeJCcdzhgYVIaFSl3wtFM4d+ri?= =?us-ascii?Q?3UjI6gnrNex/s8Idn1FSSeDG2eky59FGpaFs79/w9jblAf/05Ulph64bTNni?= =?us-ascii?Q?3RmG5Bow0GwsXaye3Z5+ECx6aSECJlH7xArEAJ/iaRro14eTP8vhLJuG8kNl?= =?us-ascii?Q?nwGjfGlifO2+3t7NTrmo6R6WZL8gg6NlYPPGsho9ZjRyHCq6lE8FmQItFXog?= =?us-ascii?Q?r5YtVXCq6RNslZ8j8FAjUyQzsPolWUG3JqycpdSLD9wxeQlBhKtdtpU/wdqc?= =?us-ascii?Q?Lx1gtH8rfKncrBvI60AvChTNp9Nxs1qj8o4ZCwYyZwLKKoLTiLDUDeC23Y26?= =?us-ascii?Q?k36aOuS9jqn9UAi6W8baQXGwzOcqdzyaTaJhtVQ4KtGf3XrqYAaz4utzJ+48?= =?us-ascii?Q?aZQnGIEoMxHMeg+c7wrYQXVWrS7ZZT1DK0Y5pa3vMpurdg0Qd4zaddSS/l3G?= =?us-ascii?Q?ftE+Iw+DvHKq7LWUZ/mUeniTJMkSQvTN8eRda4aLyr+t+1pF4aZVNuQ=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1871;6:md1LRz/OGN/I5+GOqHUg9xNVLh24rCi6HbtKSZJw8sAHhVwLZwqEXq82bVo/ofUPZWZCxhcpUqceGiWM/qBRqqOti4u2EVq/zgZhBh18udC+5df4DIuDL4gtXbfhnLpLQOr/j4L/p8SfpUyeLZuLGtl3ioIUAgICkjQBZw3Uq2TedUeHmg0d+SCdo7awFMmp/WflSDXsDbqiIJcihd+ueLW/i+4iYilnzRjuqAXlIkDLB60hFJ+QmaXBcDkT/58KBCtJ0N1DreVDrx0HbM0NVUJ8IzB/v1cw4tO3GeGXIDr4GZiiYaSRl5GNhXVqXSNn;5:gLqK8m2gXyJ8F4texOG5+v1RvPx4Kqu062bOjD/5UwP3fq78GhMNVDOCJ8Rh05SOha6PstR8fx4EjYqQzDN3N2taw+8v2v80KrafSwZTLNANkx1e2VOj6r/69NL6fCftB5RE+yrAp1kl6Nq4aFoxVw==;24:dJxvncpTGcJK85vfLfwkxXF4tAiCNCj2a0KZlG+8N13DJT6AppewcDNoc7w1xfAJ7U6cQyytJDBhw9EBId5OYQOUtdQAwJH6VdAj7nlAAZ0=;7:S9njy8uBv42CdwegicAhX3CwgnfUrYd/DRRgU4fAFBeex+MzdBn4vwr1JOLFSXOZfCYs8Rtj1OCAHUeudUsdFdAKgCD5wYRaQZGFcCWLDxbq/A8HJ2QHvGBDo4zFh350LK3oj2+HUTFBmbvin3N6UlCn/kd8+ACNcwKCfMn6fHcxFdmMDdI4DcI+05o0eGTWpO7Y3TFmOfOffgDDZSOAOOgIpZRXX9XEkxO38uagzR5PT6qn283+S6gB0d3MjYvP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1871;20:wM5WyjYhSOJNxF8Do+sUX8XWxmDMxuA6RbHpawPhUpRCtK6Xz9m6Juq3VoJktJ8Cw3+KlYlMehxrsGKq94ZzP0PGlC+U3eSVPYA47M77HzR9kZnaRCdSU4bTRW0RRLZ6IGLZiA6s2y08uufPX577PZSvsAmZaW8yBNQmTsJBnXs= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2016 12:42:26.3626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1871 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 01:51:12PM +0200, Michal Hocko wrote: > On Mon 01-08-16 16:13:08, Vladimir Davydov wrote: > > Radix trees may be used not only for storing page cache pages, so > > unconditionally accounting radix tree nodes to the current memory cgroup > > is bad: if a radix tree node is used for storing data shared among > > different cgroups we risk pinning dead memory cgroups forever. So let's > > only account radix tree nodes if it was explicitly requested by passing > > __GFP_ACCOUNT to INIT_RADIX_TREE. Currently, we only want to account > > page cache entries, so mark mapping->page_tree so. > > > > Signed-off-by: Vladimir Davydov > > OK, the patch makes sense to me. Such a false sharing would be really > tedious to debug > > Do we want to mark it for stable 4.6 to prevent from some pathological > issues. The patch is simple enough. Makes sense, expecially taking into account that kmemcg is enabled by default now. I'll resend the patch for stable then. > > Acked-by: Michal Hocko Thanks!