From: Pavel Machek <pavel@ucw.cz>
To: Baole Ni <baolex.ni@intel.com>
Cc: rjw@rjwysocki.net, len.brown@intel.com,
gregkh@linuxfoundation.org, hpa@zytor.com, x86@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com
Subject: Re: [PATCH 0077/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 14:42:56 +0200 [thread overview]
Message-ID: <20160802124256.GA25315@amd> (raw)
In-Reply-To: <20160802103855.18883-1-baolex.ni@intel.com>
On Tue 2016-08-02 18:38:55, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
Sorry, the macros just make it _less_ readable, because you do chmod
666, not chmod S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH.
NAK.
Pavel
> -static DEVICE_ATTR(control, 0644, control_show, control_store);
> +static DEVICE_ATTR(control, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH, control_show, control_store);
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-08-02 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:38 [PATCH 0077/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 12:42 ` Pavel Machek [this message]
2016-08-03 7:29 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802124256.GA25315@amd \
--to=pavel@ucw.cz \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox