From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965270AbcHBMth (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 08:49:37 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:33199 "EHLO
	mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S935102AbcHBMph (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 08:45:37 -0400
Date: Tue, 2 Aug 2016 14:45:03 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: memcontrol: add sanity checks for memcg->id.ref
 on get/put
Message-ID: <20160802124503.GK12403@dhcp22.suse.cz>
References: <01cbe4d1a9fd9bbd42c95e91694d8ed9c9fc2208.1470057819.git.vdavydov@virtuozzo.com>
 <ad702144f24374cbfb3a35b71658a0ae24ba7d84.1470057819.git.vdavydov@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ad702144f24374cbfb3a35b71658a0ae24ba7d84.1470057819.git.vdavydov@virtuozzo.com>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon 01-08-16 16:26:26, Vladimir Davydov wrote:
[...]
>  static struct mem_cgroup *mem_cgroup_id_get_active(struct mem_cgroup *memcg)
>  {
> -	while (!atomic_inc_not_zero(&memcg->id.ref))
> +	while (!atomic_inc_not_zero(&memcg->id.ref)) {
> +		VM_BUG_ON(mem_cgroup_is_root(memcg));
>  		memcg = parent_mem_cgroup(memcg);
> +	}

why is this BUG_ON ok? What if the root.use_hierarchy=true?

>  	return memcg;
>  }
-- 
Michal Hocko
SUSE Labs