From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966552AbcHBN3S (ORCPT ); Tue, 2 Aug 2016 09:29:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:42096 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966653AbcHBN0y (ORCPT ); Tue, 2 Aug 2016 09:26:54 -0400 Date: Tue, 2 Aug 2016 10:26:48 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH] perf tools: Fix build failture on perl script context Message-ID: <20160802132648.GE26514@kernel.org> References: <20160802024317.31725-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802024317.31725-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 02, 2016 at 11:43:17AM +0900, Namhyung Kim escreveu: > On my Archlinux machine, perf faild to build like below: > > CC scripts/perl/Perf-Trace-Util/Context.o > In file included from /usr/lib/perl5/core/perl/CORE/perl.h:3905:0, > from Context.xs:23: > /usr/lib/perl5/core/perl/CORE/inline.h: In function : > /usr/lib/perl5/core/perl/CORE/cop.h:612:13: warning: declaration of 'av' > shadows a previous local [-Werror-shadow] > AV *av =3D GvAV(PL_defgv); > ^ > /usr/lib/perl5/core/perl/CORE/inline.h:526:5: note: in expansion of > macro 'CX_POP_SAVEARRAY' > CX_POP_SAVEARRAY(cx); > ^~~~~~~~~~~~~~~~ > In file included from /usr/lib/perl5/core/perl/CORE/perl.h:5853:0, > from Context.xs:23: > /usr/lib/perl5/core/perl/CORE/inline.h:518:9: note: > shadowed declaration is here > AV *av; > ^~ Ok, reproduced here with yet another container image for regularly building perf: CC /tmp/build/perf/util/usage.o In file included from /usr/lib/perl5/core_perl/CORE/perl.h:3905:0, from Context.xs:23: /usr/lib/perl5/core_perl/CORE/inline.h: In function 'S_cx_popsub_args': /usr/lib/perl5/core_perl/CORE/cop.h:612:13: error: declaration of 'av' shadows a previous local [-Werror=shadow] AV *av = GvAV(PL_defgv); \ ^ /usr/lib/perl5/core_perl/CORE/inline.h:526:5: note: in expansion of macro 'CX_POP_SAVEARRAY' CX_POP_SAVEARRAY(cx); ^~~~~~~~~~~~~~~~ In file included from /usr/lib/perl5/core_perl/CORE/perl.h:5853:0, from Context.xs:23: /usr/lib/perl5/core_perl/CORE/inline.h:518:9: note: shadowed declaration is here AV *av; ^~ CC /tmp/build/perf/util/dso.o cc1: all warnings being treated as errors mv: cannot stat '/tmp/build/perf/scripts/perl/Perf-Trace-Util/.Context.o.tmp': No such file or directory make[4]: *** [/git/linux/tools/build/Makefile.build:78: /tmp/build/perf/scripts/perl/Perf-Trace-Util/Context.o] Error 1 make[3]: *** [/git/linux/tools/build/Makefile.build:116: perl/Perf-Trace-Util] Error 2 make[2]: *** [/git/linux/tools/build/Makefile.build:116: scripts] Error 2 make[2]: *** Waiting for unfinished jobs.... CC /tmp/build/perf/util/symbol.o --------------------------------------------------- this time based on: docker run -v /home/acme/git:/git:Z --rm -ti docker.io/base/archlinux:2015.06.01 /bin/bash pacman -Syu --noconfirm && pacman -Sy --noconfirm make gcc flex bison ---- thanks for the patch, will test and push out. - Arnaldo > > Signed-off-by: Namhyung Kim > --- > tools/perf/scripts/perl/Perf-Trace-Util/Build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Build b/tools/perf/scripts/perl/Perf-Trace-Util/Build > index 928e110179cb..34faecf774ae 100644 > --- a/tools/perf/scripts/perl/Perf-Trace-Util/Build > +++ b/tools/perf/scripts/perl/Perf-Trace-Util/Build > @@ -1,3 +1,5 @@ > libperf-y += Context.o > > -CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-nested-externs -Wno-undef -Wno-switch-default > +CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes > +CFLAGS_Context.o += -Wno-unused-parameter -Wno-nested-externs -Wno-undef > +CFLAGS_Context.o += -Wno-switch-default -Wno-shadow > -- > 2.9.2