From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966675AbcHBNrj (ORCPT ); Tue, 2 Aug 2016 09:47:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:46296 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966070AbcHBNrX (ORCPT ); Tue, 2 Aug 2016 09:47:23 -0400 Date: Tue, 2 Aug 2016 10:29:22 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH] perf tools: Fix build failture on perl script context Message-ID: <20160802132922.GF26514@kernel.org> References: <20160802024317.31725-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802024317.31725-1-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 02, 2016 at 11:43:17AM +0900, Namhyung Kim escreveu: > On my Archlinux machine, perf faild to build like below: > > CC scripts/perl/Perf-Trace-Util/Context.o > In file included from /usr/lib/perl5/core/perl/CORE/perl.h:3905:0, > from Context.xs:23: > /usr/lib/perl5/core/perl/CORE/inline.h: In function : > /usr/lib/perl5/core/perl/CORE/cop.h:612:13: warning: declaration of 'av' > shadows a previous local [-Werror-shadow] > AV *av =3D GvAV(PL_defgv); > ^ > /usr/lib/perl5/core/perl/CORE/inline.h:526:5: note: in expansion of > macro 'CX_POP_SAVEARRAY' > CX_POP_SAVEARRAY(cx); > ^~~~~~~~~~~~~~~~ > In file included from /usr/lib/perl5/core/perl/CORE/perl.h:5853:0, > from Context.xs:23: > /usr/lib/perl5/core/perl/CORE/inline.h:518:9: note: > shadowed declaration is here > AV *av; > ^~ But you forgot to describe _what_ you did to "fix" the problem besides breaking down a long line, i.e. adding -Wno-shadow, is that what we want? To ignore such warnings? Some explanation in the changelog as to why that is the wise solution would help a lot :-\ - Arnaldo > > Signed-off-by: Namhyung Kim > --- > tools/perf/scripts/perl/Perf-Trace-Util/Build | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/scripts/perl/Perf-Trace-Util/Build b/tools/perf/scripts/perl/Perf-Trace-Util/Build > index 928e110179cb..34faecf774ae 100644 > --- a/tools/perf/scripts/perl/Perf-Trace-Util/Build > +++ b/tools/perf/scripts/perl/Perf-Trace-Util/Build > @@ -1,3 +1,5 @@ > libperf-y += Context.o > > -CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes -Wno-unused-parameter -Wno-nested-externs -Wno-undef -Wno-switch-default > +CFLAGS_Context.o += $(PERL_EMBED_CCOPTS) -Wno-redundant-decls -Wno-strict-prototypes > +CFLAGS_Context.o += -Wno-unused-parameter -Wno-nested-externs -Wno-undef > +CFLAGS_Context.o += -Wno-switch-default -Wno-shadow > -- > 2.9.2