From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935665AbcHBQ6L (ORCPT ); Tue, 2 Aug 2016 12:58:11 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:51104 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935658AbcHBQ4u (ORCPT ); Tue, 2 Aug 2016 12:56:50 -0400 Date: Tue, 2 Aug 2016 15:46:34 +0200 From: Greg KH To: "Matwey V. Kornilov" Cc: Baole Ni , Jiri Slaby , m.chehab@samsung.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com, linux-serial@vger.kernel.org, linux-kernel , andriy.shevchenko@linux.intel.com, phillip.raffeck@fau.de, anton.wuerfel@fau.de, Peter Hurley , yamada.masahiro@socionext.com, wan.ahmad.zainie.wan.mohamad@intel.com, mail@maciej.szmigiero.name, chuansheng.liu@intel.com Subject: Re: [PATCH 0967/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802134634.GA26043@kroah.com> References: <20160802120332.14527-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 04:34:20PM +0300, Matwey V. Kornilov wrote: > And actually S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH can be simplified > to S_IRUGO | S_IWUSR, not? > I think we need to have and use dedicated special macros for most > common magic octal permissions like 0755 or 0644. We already do have them, the developer here decided to not use them for some unknown reason, making all 1285 of these patches wrong :(