From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932874AbcHBOSo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 10:18:44 -0400
Received: from mail.kernel.org ([198.145.29.136]:52460 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755419AbcHBOSc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 10:18:32 -0400
Date: Tue, 2 Aug 2016 11:18:28 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Steven Rostedt <rostedt@goodmis.org>,
        Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 0/4] tools lib traceevent: Install fixes
Message-ID: <20160802141828.GC9647@kernel.org>
References: <1470073292-18114-1-git-send-email-jolsa@kernel.org>
 <20160802031055.GB25068@danjae.aot.lge.com>
 <20160802093134.GB2036@krava>
 <20160802094823.4a58b42f@gandalf.local.home>
 <20160802140144.GA18401@krava>
 <20160802141411.GC6968@danjae.aot.lge.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160802141411.GC6968@danjae.aot.lge.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.6.2 (2016-07-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Aug 02, 2016 at 11:14:11PM +0900, Namhyung Kim escreveu:
> On Tue, Aug 02, 2016 at 04:01:44PM +0200, Jiri Olsa wrote:
> > On Tue, Aug 02, 2016 at 09:48:23AM -0400, Steven Rostedt wrote:
> > 
> > SNIP
> > 
> > > > > 
> > > > > 
> > > > > Also I think it'd be better for libtraceevent has dependency to libdl
> > > > > explicitly so that we can get rid of -ldl at the end.  
> > > > 
> > > > agreed, I'll queue your patch if v2 is needed
> > > > 
> > > 
> > > BTW, before we start making this ready for their own libraries, I'd
> > > like to make some changes with the naming convention. Mainly with
> > > event_format and format_field.
> > > 
> > > Perhaps we should change them to pevent_event and pevent_field?
> > 
> > right, it does not have any global prefix for public symbols
> > 
> > I'd actualy expect something like 'traceevent_',
> > but 'pevent' is ok as well I guess
> 
> The 'pevent' prefix would be more consistent to similar APIs IMHO.
> 
> Maybe it's worth splitting public header and internal header files?

I'd suggest exporting just what is already used by tools, exposing more
as the need arises.

- Arnaldo