From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966036AbcHBPKa (ORCPT ); Tue, 2 Aug 2016 11:10:30 -0400 Received: from mail.kernel.org ([198.145.29.136]:33756 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965384AbcHBPKH (ORCPT ); Tue, 2 Aug 2016 11:10:07 -0400 Date: Tue, 2 Aug 2016 12:10:01 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML Subject: Re: [PATCH] perf tools: Fix build failture on perl script context Message-ID: <20160802151001.GA16017@kernel.org> References: <20160802024317.31725-1-namhyung@kernel.org> <20160802132922.GF26514@kernel.org> <20160802140302.GA6968@danjae.aot.lge.com> <20160802141232.GB9647@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802141232.GB9647@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 02, 2016 at 11:12:32AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Aug 02, 2016 at 11:03:02PM +0900, Namhyung Kim escreveu: > > What I did to fix is adding '-Wno-shadow' as the error message said > > it's the cause of the failure. Since it's from the perl (not perf) > > code base, we don't have the control so I just wanted to ignore the > > warning when compiling perl scripting code. > > > > Is it ok for you? > > Now it is :-) > > I'll stick this to the changeset log as the reason for adding > -wno-shadow just for building the perl code. > > Sometimes we'll get to this conclusion after some thinking, if you add > these explanations to the changelog then it speeds up reviewing. Cool, this fixed the build as well for fedora rawhide. - Arnaldo