From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935883AbcHBRoO (ORCPT ); Tue, 2 Aug 2016 13:44:14 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47236 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936171AbcHBRm6 (ORCPT ); Tue, 2 Aug 2016 13:42:58 -0400 Date: Tue, 2 Aug 2016 19:42:54 +0200 From: Pavel Machek To: Baole Ni Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com Subject: Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802174253.GA4628@amd> References: <20160802103322.13810-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802103322.13810-1-baolex.ni@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > -core_param(no_bL_switcher, no_bL_switcher, bool, 0644); > +core_param(no_bL_switcher, no_bL_switcher, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR | S_IRCRP | S_IROTH (*). Please don't do this. Pavel (*) I deliberately included an error there. Did you spot the error? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html