From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936090AbcHBRyp (ORCPT ); Tue, 2 Aug 2016 13:54:45 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47484 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936039AbcHBRye (ORCPT ); Tue, 2 Aug 2016 13:54:34 -0400 Date: Tue, 2 Aug 2016 19:54:30 +0200 From: Pavel Machek To: Joe Perches Cc: Baole Ni , linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com Subject: Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802175430.GA22232@amd> References: <20160802103322.13810-1-baolex.ni@intel.com> <20160802174253.GA4628@amd> <1470160338.3998.193.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470160338.3998.193.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 2016-08-02 10:52:18, Joe Perches wrote: > On Tue, 2016-08-02 at 19:42 +0200, Pavel Machek wrote: > > > I find that the developers often just specified the numeric value > > > when calling a macro which is defined with a parameter for access permission. > > > As we know, these numeric value for access permission have had the corresponding macro, > > > and that using macro can improve the robustness and readability of the code, > > > thus, I suggest replacing the numeric parameter with the macro. > > > > > > -core_param(no_bL_switcher, no_bL_switcher, bool, 0644); > > > +core_param(no_bL_switcher, no_bL_switcher, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); > > > Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR | > > S_IRCRP | S_IROTH (*). Please don't do this. > > Perhaps this conversion is best done in reverse with > most all of the S_[A-Z]{5,5} uses converted to octal. I'd prefer that, yes.. But lets discuss that before another 1200 patch patchbomb... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html