From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755986AbcHBTAv (ORCPT ); Tue, 2 Aug 2016 15:00:51 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34139 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153AbcHBTAG (ORCPT ); Tue, 2 Aug 2016 15:00:06 -0400 Date: Tue, 2 Aug 2016 11:54:47 -0700 From: Olof Johansson To: Baole Ni Cc: mchehab@kernel.org, maurochehab@gmail.com, mchehab@infradead.org, mchehab@redhat.com, m.chehab@samsung.com, egor@pasemi.com, dougthompson@xmission.com, bp@alien8.de, linuxppc-dev@lists.ozlabs.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, lee.jones@linaro.org Subject: Re: [PATCH 0157/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802185447.GA5288@localhost> References: <20160802104515.24206-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802104515.24206-1-baolex.ni@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 06:45:15PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. Am I the only one who find the readability to be MUCH better for the numeric values? -Olof