From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jan Stancek <jstancek@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org, xiakaixu@huawei.com,
cjashfor@linux.vnet.ibm.com, dsahern@gmail.com,
fweisbec@gmail.com, jolsa@kernel.org, namhyung@kernel.org,
paulus@samba.org, a.p.zijlstra@chello.nl
Subject: Re: [PATCH] perf tests: objdump output can contain multi byte chunks
Date: Tue, 2 Aug 2016 16:47:28 -0300 [thread overview]
Message-ID: <20160802194728.GC14639@kernel.org> (raw)
In-Reply-To: <20160802193316.GB14639@kernel.org>
Em Tue, Aug 02, 2016 at 04:33:16PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Aug 02, 2016 at 04:07:00PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Wed, Jan 13, 2016 at 10:22:04AM +0200, Adrian Hunter escreveu:
> > > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > Oops, this one got lost, finally applying...
> Ok, it failed for:
> ubuntu:16.04-x-armhf: FAIL
> ubuntu:16.04-x-powerpc64: FAIL
>
> Both are related to, which I am fixing:
>
> CC /tmp/build/perf/tests/code-reading.o
> In file included from /git/linux/tools/perf/util/cpumap.h:9:0,
> from /git/linux/tools/perf/util/evsel.h:11,
> from /git/linux/tools/perf/util/evlist.h:10,
> from tests/code-reading.c:9:
> tests/code-reading.c: In function 'read_via_objdump':
> tests/code-reading.c:197:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=]
> pr_debug("objdump read too few bytes: %lu\n", len);
> ^
> /git/linux/tools/perf/util/debug.h:18:21: note: in definition of macro 'pr_fmt'
> #define pr_fmt(fmt) fmt
> ^
> tests/code-reading.c:197:3: note: in expansion of macro 'pr_debug'
> pr_debug("objdump read too few bytes: %lu\n", len);
> ^
Just use %zd for size_t:
[root@jouet ~]# dm ubuntu:16.04-x-armhf ubuntu:16.04-x-powerpc64
1: ubuntu:16.04-x-armhf: Ok
2: ubuntu:16.04-x-powerpc64: Ok
[root@jouet ~]#
- Arnaldo
next prev parent reply other threads:[~2016-08-02 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 10:07 [PATCH] perf tests: objdump output can contain multi byte chunks Jan Stancek
2016-01-12 15:30 ` Arnaldo Carvalho de Melo
2016-01-13 8:22 ` Adrian Hunter
2016-08-02 19:07 ` Arnaldo Carvalho de Melo
2016-08-02 19:33 ` Arnaldo Carvalho de Melo
2016-08-02 19:47 ` Arnaldo Carvalho de Melo [this message]
2016-08-04 9:14 ` [tip:perf/urgent] " tip-bot for Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802194728.GC14639@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=dsahern@gmail.com \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jstancek@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=xiakaixu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox