From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757486AbcHBT4V (ORCPT ); Tue, 2 Aug 2016 15:56:21 -0400 Received: from mail.kernel.org ([198.145.29.136]:54312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757454AbcHBT4K (ORCPT ); Tue, 2 Aug 2016 15:56:10 -0400 Date: Tue, 2 Aug 2016 16:47:28 -0300 From: Arnaldo Carvalho de Melo To: Jan Stancek Cc: Adrian Hunter , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, xiakaixu@huawei.com, cjashfor@linux.vnet.ibm.com, dsahern@gmail.com, fweisbec@gmail.com, jolsa@kernel.org, namhyung@kernel.org, paulus@samba.org, a.p.zijlstra@chello.nl Subject: Re: [PATCH] perf tests: objdump output can contain multi byte chunks Message-ID: <20160802194728.GC14639@kernel.org> References: <07f0f7bcbda78deb423298708ef9b6a54d6b92bd.1452592712.git.jstancek@redhat.com> <20160112153054.GF21083@redhat.com> <5696092C.30100@intel.com> <20160802190700.GA14639@kernel.org> <20160802193316.GB14639@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160802193316.GB14639@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Aug 02, 2016 at 04:33:16PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Tue, Aug 02, 2016 at 04:07:00PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Jan 13, 2016 at 10:22:04AM +0200, Adrian Hunter escreveu: > > > Acked-by: Adrian Hunter > > Oops, this one got lost, finally applying... > Ok, it failed for: > ubuntu:16.04-x-armhf: FAIL > ubuntu:16.04-x-powerpc64: FAIL > > Both are related to, which I am fixing: > > CC /tmp/build/perf/tests/code-reading.o > In file included from /git/linux/tools/perf/util/cpumap.h:9:0, > from /git/linux/tools/perf/util/evsel.h:11, > from /git/linux/tools/perf/util/evlist.h:10, > from tests/code-reading.c:9: > tests/code-reading.c: In function 'read_via_objdump': > tests/code-reading.c:197:12: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=] > pr_debug("objdump read too few bytes: %lu\n", len); > ^ > /git/linux/tools/perf/util/debug.h:18:21: note: in definition of macro 'pr_fmt' > #define pr_fmt(fmt) fmt > ^ > tests/code-reading.c:197:3: note: in expansion of macro 'pr_debug' > pr_debug("objdump read too few bytes: %lu\n", len); > ^ Just use %zd for size_t: [root@jouet ~]# dm ubuntu:16.04-x-armhf ubuntu:16.04-x-powerpc64 1: ubuntu:16.04-x-armhf: Ok 2: ubuntu:16.04-x-powerpc64: Ok [root@jouet ~]# - Arnaldo