From: "Theodore Ts'o" <tytso@mit.edu>
To: Baole Ni <baolex.ni@intel.com>
Cc: adilger.kernel@dilger.ca, david.vrabel@citrix.com,
tomi.valkeinen@ti.com, m.chehab@samsung.com,
gregkh@linuxfoundation.org, m.szyprowski@samsung.com,
kyungmin.park@samsung.com, k.kozlowski@samsung.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com, mhalcrow@google.com,
kirill.shutemov@linux.intel.com, oneukum@suse.com
Subject: Re: [PATCH 1038/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 17:17:02 -0400 [thread overview]
Message-ID: <20160802211702.GA11745@thunk.org> (raw)
In-Reply-To: <20160802121047.19315-1-baolex.ni@intel.com>
On Tue, Aug 02, 2016 at 08:10:47PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
I actually find using the macros significantly **decrease* the
readiability of the code. A quick glance at 0644 quickly tells you
what the permissions are. Parsing S_IRUSR | S_IRGRP | S_IROTH takes
longer, and is more error prone.
NACK.
- Ted
prev parent reply other threads:[~2016-08-02 21:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 12:10 [PATCH 1038/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 21:17 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802211702.GA11745@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=david.vrabel@citrix.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mhalcrow@google.com \
--cc=oneukum@suse.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox