The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Masami Hiramatsu <mhiramat@kernel.org>
To: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
Cc: linux-kernel@vger.kernel.org, masumi.moritani.ju@hitachi.com,
	Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 2/2 v5] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel
Date: Tue, 2 Aug 2016 22:19:01 +0900	[thread overview]
Message-ID: <20160802221901.23a0f99a5a815360b59a7bbe@kernel.org> (raw)
In-Reply-To: <1470116129-12380-2-git-send-email-tomoki.sekiyama.qu@hitachi.com>

On Tue,  2 Aug 2016 14:35:29 +0900
Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com> wrote:

> Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
> kernel.
> 
> Related kernel commits:
>  - commit ad86622b478e ("wait: swap EXIT_ZOMBIE and EXIT_DEAD to hide
>    EXIT_TRACE from user-space"):
>    'Z' and 'X' are swapped
> 
>  - commit 80ed87c8a9ca ("sched/wait: Introduce TASK_NOLOAD and TASK_IDLE"):
>    Introduces new state 'N'
> 
>  - commit 7dc603c9028e ("sched/fair: Fix PELT integrity for new tasks"):
>    Introduces new state 'n'
> 

Ah, here is the newer one :)

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thanks!

> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: David Ahern <dsahern@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> Changes from v4:
>   Removed 'Fixes:' tag and added related commits in the commit message
> 
>  tools/perf/builtin-sched.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> index ce9bef6..5776263 100644
> --- a/tools/perf/builtin-sched.c
> +++ b/tools/perf/builtin-sched.c
> @@ -70,7 +70,7 @@ struct sched_atom {
>  	struct task_desc	*wakee;
>  };
>  
> -#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
> +#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
>  
>  enum thread_state {
>  	THREAD_SLEEPING = 0,
> -- 
> 2.7.4
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>

  reply	other threads:[~2016-08-02 13:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02  5:35 [PATCH 1/2 v5] perf sched: fix wrong conversion of task state Tomoki Sekiyama
2016-08-02  5:35 ` [PATCH 2/2 v5] perf sched: adapt TASK_STATE_TO_CHAR_STR to the latest kernel Tomoki Sekiyama
2016-08-02 13:19   ` Masami Hiramatsu [this message]
2016-08-02 13:21   ` David Ahern
2016-08-02 13:19 ` [PATCH 1/2 v5] perf sched: fix wrong conversion of task state Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160802221901.23a0f99a5a815360b59a7bbe@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masumi.moritani.ju@hitachi.com \
    --cc=namhyung@kernel.org \
    --cc=tomoki.sekiyama.qu@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox