From: Ralf Baechle <ralf@linux-mips.org>
To: Keguang Zhang <keguang.zhang@gmail.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via platform data
Date: Wed, 3 Aug 2016 08:14:20 +0200 [thread overview]
Message-ID: <20160803061419.GH15910@linux-mips.org> (raw)
In-Reply-To: <1464429112-27590-2-git-send-email-keguang.zhang@gmail.com>
On Sat, May 28, 2016 at 05:51:52PM +0800, Keguang Zhang wrote:
> diff --git a/arch/mips/include/asm/mach-loongson32/nand.h b/arch/mips/include/asm/mach-loongson32/nand.h
> index e274912..a1f8704 100644
> --- a/arch/mips/include/asm/mach-loongson32/nand.h
> +++ b/arch/mips/include/asm/mach-loongson32/nand.h
> @@ -21,10 +21,9 @@ struct plat_ls1x_nand {
>
> int hold_cycle;
> int wait_cycle;
> + bool (*dma_filter)(struct dma_chan *chan, void *param);
> };
>
> extern struct plat_ls1x_nand ls1b_nand_pdata;
>
> -bool ls1x_dma_filter_fn(struct dma_chan *chan, void *param);
> -
> #endif /* __ASM_MACH_LOONGSON32_NAND_H */
> diff --git a/arch/mips/loongson32/ls1b/board.c b/arch/mips/loongson32/ls1b/board.c
> index 38a1d40..0a57337 100644
> --- a/arch/mips/loongson32/ls1b/board.c
> +++ b/arch/mips/loongson32/ls1b/board.c
> @@ -38,6 +38,7 @@ struct plat_ls1x_nand ls1x_nand_pdata = {
> .nr_parts = ARRAY_SIZE(ls1x_nand_parts),
> .hold_cycle = 0x2,
> .wait_cycle = 0xc,
> + .dma_filter = ls1x_dma_filter,
> };
Without the DMA driver which Vinod has requested changes for this
patch will result in build errors. It will also result in a build
error if CONFIG_LOONGSON1_DMA is disabled.
Ralf
prev parent reply other threads:[~2016-08-03 6:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 9:51 [PATCH] MIPS: Loongson1B: Remove ARCH_WANT_OPTIONAL_GPIOLIB Keguang Zhang
2016-05-28 9:51 ` [PATCH] MIPS: Loongson1B: Provide DMA filter callbacks via platform data Keguang Zhang
2016-08-03 6:14 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803061419.GH15910@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=keguang.zhang@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).