From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757781AbcHCK4Y (ORCPT ); Wed, 3 Aug 2016 06:56:24 -0400 Received: from mail-db5eur01on0113.outbound.protection.outlook.com ([104.47.2.113]:51264 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756771AbcHCK4R (ORCPT ); Wed, 3 Aug 2016 06:56:17 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=VDavydov@virtuozzo.com; Date: Wed, 3 Aug 2016 11:15:25 +0300 From: Vladimir Davydov To: Greg KH CC: , Johannes Weiner , "Michal Hocko" , , Subject: Re: [PATCH stable 4.6+] radix-tree: account nodes to memcg only if explicitly requested Message-ID: <20160803081525.GF13263@esperanza> References: <1470141934-4568-1-git-send-email-vdavydov@virtuozzo.com> <20160803035139.GB31125@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160803035139.GB31125@kroah.com> X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM2PR09CA0028.eurprd09.prod.outlook.com (10.161.22.166) To HE1PR0801MB1865.eurprd08.prod.outlook.com (10.168.94.8) X-MS-Office365-Filtering-Correlation-Id: f603a44b-9e26-4e44-7bc9-08d3bb765556 X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1865;2:zApLa//B2oPKJA/GU7Kl0QrgJk+C2HGg9YArWPvRJd1vOsP34fBoe2tdgqiYake3gEPNZFoIBE4tDjKQ5pUeFhDs1kcuFVPbf2dNHyfiDFm1/vtU0JaqwSEsS6vzHlkcUJ4RKDLXTdSsdBn+jaCMZxtUG50SkMWB3FZwWchwxVuNBS9IqbbRJyT9Y5bWiPHv;3:PYbZ0KOTFW4yJpTM7V4VZZw+xGnOvtA5oAyFelZBMdB/9VU25JVo+y8PXpKF1LwM/bH48AedIUhHefuOIXQGnwZnijzH4KvdDtIVg/gDeGRXZ/oi7PL9bYcsLsA02wo1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1865; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1865;25:mDHmWdktQrrlaUQvr1Wqkf04smy8gB6fq/w31wAEtDDVLtSErP8iF3WCQ9bLLD5fdUqr9oU/EA5Ti0/w8E1AIlJgzNn6U567pfsuMOJ+r9dvqbXl7PM2zb+NBbHRjNXQYZKnSWGS0YhtdoY/M+fJ/Rd4MG1icIm12LktaJwnJTN1Xby/VOzq7wwPz7It32xLGfL/5XkmfjOoAz9Dj1IcVwWjl4HJdbkzLvHw6ShprJiiJ5QKErowkW0WKbnl+zRgLJK4xqK/+lQVzd0A0tZm9WMdgJMlA+SnAvdh4QT1NciLFNEXDCRSwWDBdZRezl9CznT83RSap0oCWSX5P7yD8vFDmgPN/7DtAU8wHZ31EKyGL9uU/7IBUX3lSQS6wTeKmUHHalffReC/8la0YtkJCbEdt2I7huzT0mtnrmYFeNZLhvuEdz7sgvfa3LOJURyBIidVyfqcGSA1rWhCjzC9jVE/KboSLX13RDB5xD6797j8jEBvPyEmfJyj1a/T46lE44ldqX5MitPmSeCJp7HBlUstVOwvEHQ7Y1TcS/l3veiRpRG9YpXmEPEMbUGRkQ87FAyqf63uwKr0Gj1Z+Vh7Y7knF7PAiHfDv1Gi+FvsJWaUauEd1ndh9otcuquyammDaehBXmW6R4d10YAeyqFo0+4H+KylSkuIUpIERIWVZtEqOb+OyFEKyTPXSgJghUFlTvKP9J95EdlrhyH6s9XvRN3S0cdYSVYaQiE0qJgHodLJDa3kQ3m2FStPj2Wjv2Vs X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1865;31:6LdH3nA4aftrKpJbifWmF76No9ecGnqjQZ20t1yYyUeIQpUbMFnhwk8D7NOAIh43zmJyAg95meY/NwY69fyasB8+63qDKSE0m5NOBSELlf5C5LD4i26XOKl16fr3jvUenxar8qRAGiBocS4ehyl1OZCb0uAf0y0vDwrB/htqiA8D52Nrft8yLJWPi6IYM/xqjooGFIMVM1JXSpM0jPLRe/2j8Ujnpfp6w+PqvweJePo=;4:4XJVTxehpisAtRGopYCJlypPgQtqcPzAPxCK6qXcfCFZSYIPzKywfeOcC9mQuBSTBsGoD1dpF+tdL7PMEJXaX5/snSyd9utrkpasCW9A5vnPH3+vGy+rHkRY6MI68SBTUfNymb37h2xPKxVhsrWheYrhGc7GIX6+l47EvoDXxf3mIg+DLeOu8m4Mp5JcyNwlHJJAuzvguT8nQb4+p2AnU1jFhXVMtvnl0WCT/O1W3PeWiXSCE0L/FBzVQhtjq6TCIfQviGzeAdz47KsACY+nVLJUqA4XLF69DIn7Bu5P8muA5SHnNpDwKYbGlj9yDZrObXK3r/DwdFmys/1kwBbIIVuGUHcuYuLe/XZC0zsxvqLgCjZOkQgFK/QZm9WXoVpuuke65F6prqyuULytbHAZCeZgdzSQXzglP4bp+EfvNrlKwk7kVxlnVFvgXU3xOJztvQTjpskACRNsD9wnyLs+8Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(9452136761055); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046);SRVR:HE1PR0801MB1865;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1865; X-Forefront-PRVS: 00235A1EEF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(189002)(199003)(24454002)(305945005)(6116002)(19580405001)(9686002)(86362001)(68736007)(7736002)(3846002)(33716001)(1076002)(19580395003)(586003)(7846002)(101416001)(97756001)(106356001)(23726003)(105586002)(15650500001)(76176999)(97736004)(66066001)(77096005)(50986999)(33656002)(8676002)(81156014)(42186005)(47776003)(80792005)(81166006)(2950100001)(46406003)(2906002)(54356999)(50466002)(92566002)(110136002)(4326007)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1865;H:esperanza;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;HE1PR0801MB1865;23:e8F2QoqcjPPmQgnLlRK75egFZnHzP6AQbE5+Ysc?= =?us-ascii?Q?EV7mS22F54PhjtfOq9O5TN3cCqSs8CHJi8a1rK1MkgHPswpZXwCCWAYAGvK/?= =?us-ascii?Q?PuJuP3/89bDCS+4pYytv4Nmrz+q9RrffwzuIpl6nBXmxUfI94ipAwSiQ2Jtp?= =?us-ascii?Q?12zQN50yreT1ygeg96Y6ol+2xX5m0fAIx8gZOyIurqrSq5hxA56FXN45S/Eo?= =?us-ascii?Q?8JPwPh+cqjLkii9mwnPxPg1aj313Cc4yOYMf6CTTisLAh6q0Al7NXRShrkne?= =?us-ascii?Q?87dZvIWgLmgi56WgJCocYD/vSllyC41twINOYtxMugPfiMwbx+/PFM/yPjhu?= =?us-ascii?Q?9DI5prsmSn9hwKMFEJEKV4o03tEHw+/dsdE8SmKkW5JQ+8740PonnZTqA/PG?= =?us-ascii?Q?CZI7NKpJd2YOUmw+krrvzw0sEEksmk93BYxZQ6V2nLYtojCB7pGJppg9KxRb?= =?us-ascii?Q?mH2Ilz9o1a0M9CHAqLuoxVXPFJKkRV/5xxhv8in5ftq0uzWPZGCbYc1EqGR1?= =?us-ascii?Q?KW4BzWaw57yd1Nr4k5DYJSTx8Rf2KDmrrg+UgeOX3nf+rddco7pmZnhu5jJY?= =?us-ascii?Q?ujf8ihwOIz2g1sXgHxJcf+f+QxLWDiymZ+hA241H2Mz8syF6wrIBrD4ckkED?= =?us-ascii?Q?OezFVs7wUojQkvWp1fEHTxPgZKDlOtmDQVCY4Lft9C5M4bUhWIIlEzX8JDsw?= =?us-ascii?Q?GX0VEBByckiKL9wRcx8Wlib+j5bqQ6gNdEVIpuvJrc//XaJaf4PQ4sdhaFU+?= =?us-ascii?Q?Y5hOJ9thpPJSPyIjMpUAhn7U2AcBv9Zz5hn5bR8fVviGah7I7Eb6o7dnKnVF?= =?us-ascii?Q?glVeKcEw67ZxAgQ+QONhFnw1NT/6dJV7ShJvznssQZ9cNEhGFwfDSjC2vvRs?= =?us-ascii?Q?V56Xqv+3BHMIScD/gftvZms8F7zI5O3fIBX3QNE6QeTZjMNiGt5WrUtDQBIs?= =?us-ascii?Q?2t5FO+mkubjMZMkUhW7UVXd7aBbAuFgk5rjq/0M7w3lRXdTQ9ii4Pltl+WZQ?= =?us-ascii?Q?mANSSn9upTigVlmExoFg3PON2oooUIOA2gT/I9h/lXKtyQUBavsZR2xYLFPh?= =?us-ascii?Q?7wkfTs5OENZmT2aISf59qQJV4HmmidJbvbrJJjJVtHqmEB35YSUnxA+YuPuK?= =?us-ascii?Q?rszbVBDkG0J8OdMl+U1HITm6G9RAgyeS8?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1865;6:i9pmy1f72LGILkchJGB8ouU0fcZEdGrsKLqazEEBDh92tcKPyRMO7kocVB84XUE6lK2a9VerFTM7zzDHSIgvAnw2mCp8+Q0nrortHi78+ufeivtncf5JQhJ4j+63T9+37mjker0G47zAUkTVVuBBt5LD2Lg7d8M8mILDpWr2GvFu/+kwrw8PbRw2WsdrlyxUuaoTCT/dlMAoHhVygX1wR8Afwu82qmwIrm0wN/CR3Yd2jkxTQcsB3aCkRYQz+fkcuCd01PYhw8Nl+djhc27y+nqnDADsUuqnYvUvFJ+dWIicaDg3eLZ5vb19Zgz9jrWV;5:hm2JBaYUjwuSJuFu5D3W8jgo4MjlHjhII9V0Xm77jx8bzKiafqKeRl0JXtKuMH9SiHjBamL5dxP8IL86uosDuhCj0AKPWYzudPpM4sFjmXQqsW6z94dVrHm1j2vsw0JhFGq7bJDi7CG3K7z/zDqD2w==;24:rqiPfmQQMjcR6aZ9/KK+Gc0FtD5zoOczDphrLFx0RQ1ldCgwUrFV1Cc74/sIftjf18k42TQYkqfFal6hblHH48B22XVxJx/XrNpUxNaCb2c=;7:l7OEjK5isF/3F1ZBBHsZEh7lBfSwRiNYZlX70FzHbfRM3Cs3PxYlAqvgzBH6d9rxIkESmKa02E0MMgFgvbj1kNTKaZHCj8UnqcNRt/r4l3N8TTvlOSVCzVcwryfNPU5Lt/pdbjwf/JaumiRN6yp1ilB4qfyU59COUowM5HmZw+hc7foS4b3tr5kT4HEQcQ7CL2bL5wh808yoJSxNaReXR2+EPrKlLUfcPzt5ZfPpAmlrcIj3VLALoSWsYr0igVlP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1865;20:78z1ZiIwE77nT62f8dGAwQFX3XfnEgLAcYGLgHRDaMjPBpLgDZHvCDfdIoDa9/U6h8z+nH5MB2RAhqNe44ggGOKOfOqisTxA6yP8TAn4Kex/kgesjZSgrOiR3Q7gsoNbwparkXV46BmZ+Z/DBp80cat/FqSpwPhcHCupzGBhXvU= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2016 08:15:29.4612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1865 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2016 at 05:51:39AM +0200, Greg KH wrote: > On Tue, Aug 02, 2016 at 03:45:34PM +0300, Vladimir Davydov wrote: > > Radix trees may be used not only for storing page cache pages, so > > unconditionally accounting radix tree nodes to the current memory cgroup > > is bad: if a radix tree node is used for storing data shared among > > different cgroups we risk pinning dead memory cgroups forever. So let's > > only account radix tree nodes if it was explicitly requested by passing > > __GFP_ACCOUNT to INIT_RADIX_TREE. Currently, we only want to account > > page cache entries, so mark mapping->page_tree so. > > > > Signed-off-by: Vladimir Davydov > > Acked-by: Johannes Weiner > > Acked-by: Michal Hocko > > Cc: [4.6+] > > --- > > fs/inode.c | 2 +- > > lib/radix-tree.c | 14 ++++++++++---- > > 2 files changed, 11 insertions(+), 5 deletions(-) > > Is this patch in Linus's tree already? Not yet, it should only be added to 4.8, so I shouldn't have sent this (didn't know how patches are submitted to stable). Please ignore. > > confused, Sorry for the noise.