public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vladimir Davydov <vdavydov@virtuozzo.com>
Cc: stable@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH stable 4.6+] radix-tree: account nodes to memcg only if explicitly requested
Date: Wed, 3 Aug 2016 10:29:35 +0200	[thread overview]
Message-ID: <20160803082935.GB32280@kroah.com> (raw)
In-Reply-To: <20160803081525.GF13263@esperanza>

On Wed, Aug 03, 2016 at 11:15:25AM +0300, Vladimir Davydov wrote:
> On Wed, Aug 03, 2016 at 05:51:39AM +0200, Greg KH wrote:
> > On Tue, Aug 02, 2016 at 03:45:34PM +0300, Vladimir Davydov wrote:
> > > Radix trees may be used not only for storing page cache pages, so
> > > unconditionally accounting radix tree nodes to the current memory cgroup
> > > is bad: if a radix tree node is used for storing data shared among
> > > different cgroups we risk pinning dead memory cgroups forever. So let's
> > > only account radix tree nodes if it was explicitly requested by passing
> > > __GFP_ACCOUNT to INIT_RADIX_TREE. Currently, we only want to account
> > > page cache entries, so mark mapping->page_tree so.
> > > 
> > > Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>
> > > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> > > Acked-by: Michal Hocko <mhocko@suse.com>
> > > Cc: <stable@vger.kernel.org>  [4.6+]
> > > ---
> > >  fs/inode.c       |  2 +-
> > >  lib/radix-tree.c | 14 ++++++++++----
> > >  2 files changed, 11 insertions(+), 5 deletions(-)
> > 
> > Is this patch in Linus's tree already?
> 
> Not yet, it should only be added to 4.8, so I shouldn't have sent this
> (didn't know how patches are submitted to stable). Please ignore.

Please read Documentation/stable_kernel_rules.txt, it should help answer
this question (hint, you almost got it right...)

thanks,

greg k-h

      reply	other threads:[~2016-08-03  8:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 12:45 [PATCH stable 4.6+] radix-tree: account nodes to memcg only if explicitly requested Vladimir Davydov
2016-08-03  3:51 ` Greg KH
2016-08-03  8:15   ` Vladimir Davydov
2016-08-03  8:29     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160803082935.GB32280@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox