From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758034AbcHCQT4 (ORCPT ); Wed, 3 Aug 2016 12:19:56 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35759 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754499AbcHCQTv (ORCPT ); Wed, 3 Aug 2016 12:19:51 -0400 Date: Wed, 3 Aug 2016 17:23:32 +0200 From: Krzysztof Kozlowski To: Baole Ni Cc: airlied@linux.ie, kyungmin.park@samsung.com, kgene@kernel.org, k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, airlied@redhat.com, daniel.vetter@ffwll.ch, treding@nvidia.com, alexander.deucher@amd.com, ville.syrjala@linux.intel.com, chuansheng.liu@intel.com Subject: Re: [PATCH 0210/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160803152332.GA8124@kozik-book> References: <20160802105001.27759-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160802105001.27759-1-baolex.ni@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 06:50:01PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/gpu/drm/qxl/qxl_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I got almost 1000 patches out of your mail bomb. For all of them: NACK. Other people pointed actual reasons (title, readability, cc-list). The commit msg should be also written in a more readable way. Anyway, in Intel there are a lot of people having kernel contributions so it is a shame that you didn't ask them for advice how to do it... BR, Krzysztof