From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758178AbcHCTFA (ORCPT ); Wed, 3 Aug 2016 15:05:00 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:33115 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758133AbcHCTE4 (ORCPT ); Wed, 3 Aug 2016 15:04:56 -0400 Date: Wed, 3 Aug 2016 22:04:51 +0300 From: "Kirill A. Shutemov" To: Geert Uytterhoeven Cc: "Kirill A. Shutemov" , Andrew Morton , Linus Torvalds , Hugh Dickins , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] shmem: Fix link error if huge pages support is disabled Message-ID: <20160803190451.GA9830@node.shutemov.name> References: <1470247099-14217-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470247099-14217-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2016 at 07:58:19PM +0200, Geert Uytterhoeven wrote: > If CONFIG_TRANSPARENT_HUGE_PAGECACHE=n, HPAGE_PMD_NR evaluates to > BUILD_BUG_ON(), and may cause (e.g. with gcc 4.12): > > mm/built-in.o: In function `shmem_alloc_hugepage': > shmem.c:(.text+0x17570): undefined reference to `__compiletime_assert_1365' > > To fix this, move the assignment to hindex after the check for huge > pages support. > > Fixes: 800d8c63b2e989c2 ("shmem: add huge pages support") > Signed-off-by: Geert Uytterhoeven Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov