From: Masami Hiramatsu <mhiramat@kernel.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: perf test BPF failing on f24: fix
Date: Wed, 3 Aug 2016 23:45:57 +0900 [thread overview]
Message-ID: <20160803234557.29f43f755b7e14c634a54a9a@kernel.org> (raw)
In-Reply-To: <57A1A913.6000307@huawei.com>
On Wed, 3 Aug 2016 16:19:31 +0800
"Wangnan (F)" <wangnan0@huawei.com> wrote:
> Add Masami to Cc list. He knowns debug info.
>
> Please see below...
>
> On 2016/8/3 3:51, Arnaldo Carvalho de Melo wrote:
> > Hi Wang,
> >
> > Something changed and a function used in a perf test for BPF is
> > not anymore appearing on vmlinux, albeit still available on
> > /proc/kallsyms:
> >
> > # readelf -wi /lib/modules/4.7.0+/build/vmlinux | grep -w sys_epoll_wait
> > #
>
> As I have said in another mail, although I don't know why,
> I don't think the missing of sys_epoll_wait is the root cause
> of your failure.
>
> I did a bisect search and found commit
> 83460ec8dcac14142e7860a01fa59c267ac4657c:
> "syscalls.h: use gcc alias instead of assembler aliases for syscalls"
> After this commit, sys_xxx symbols is gone from output of 'readelf -wi'.
> It is
> introduced in v3.13.
>
> > But:
> >
> > [root@jouet ~]# grep -i sys_epoll_wait /proc/kallsyms
> > ffffffffbd295b50 T SyS_ep
>
> > oll_wait
> > ffffffffbd295b50 T sys_epoll_wait
> > [root@jouet ~]#
>
> If we remove vmlinux, perf should use /proc/kallsyms. I think
> the failure would gone. The problem is: when symbol searching
> fail using vmlinux, should we fallback to kallsyms? However,
> this is another question.
As below result shown, perf probe tries to fallback, but it seems to
fail to find corresponding debuginfo entry...
> > [root@jouet ~]# perf probe sys_epoll_wait
> > Failed to find debug information for address ffffffffbd295b50
> > Probe point 'sys_epoll_wait' not found.
> > Error: Failed to add events.
So, at least I should investigate it.
Thanks,
> > [root@jouet ~]# perf probe SyS_epoll_wait
> > Added new events:
> > probe:SyS_epoll_wait (on SyS_epoll_wait)
> > probe:SyS_epoll_wait_1 (on SyS_epoll_wait)
> > probe:SyS_epoll_wait_2 (on SyS_epoll_wait)
> >
> > You can now use it in all perf tools, such as:
> >
> > perf record -e probe:SyS_epoll_wait_2 -aR sleep 1
> >
> > [root@jouet ~]#
> >
> > So I am changing the BPF perf test to use the CamelCase notation alias:
>
> Changing to SyS_xxx is okay, byt we still need to know the root
> cause.
>
> Thank you.
>
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2016-08-03 14:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 19:51 perf test BPF failing on f24: fix Arnaldo Carvalho de Melo
2016-08-02 21:03 ` Alexei Starovoitov
2016-08-03 2:15 ` Arnaldo Carvalho de Melo
2016-08-03 2:57 ` Alexei Starovoitov
2016-08-03 2:41 ` Wangnan (F)
2016-08-03 3:41 ` Wangnan (F)
2016-08-03 8:19 ` Wangnan (F)
2016-08-03 14:45 ` Masami Hiramatsu [this message]
2016-08-03 20:04 ` Arnaldo Carvalho de Melo
2016-08-04 6:32 ` Masami Hiramatsu
2016-08-04 12:48 ` Arnaldo Carvalho de Melo
2016-08-04 19:36 ` Arnaldo Carvalho de Melo
2016-08-04 21:47 ` Arnaldo Carvalho de Melo
2016-08-05 9:45 ` Masami Hiramatsu
2016-08-05 14:35 ` Arnaldo Carvalho de Melo
2016-08-05 15:55 ` Arnaldo Carvalho de Melo
2016-08-06 10:29 ` Masami Hiramatsu
2016-08-08 19:33 ` Arnaldo Carvalho de Melo
2016-08-09 19:17 ` [tip:perf/urgent] perf probe: Adjust map->reloc offset when finding kernel symbol from map tip-bot for Masami Hiramatsu
2016-08-03 23:08 ` perf test BPF failing on f24: fix Masami Hiramatsu
2016-08-04 1:50 ` Wangnan (F)
2016-08-04 8:47 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160803234557.29f43f755b7e14c634a54a9a@kernel.org \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).