From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751871AbcHDGOD (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Aug 2016 02:14:03 -0400
Received: from mail-pf0-f193.google.com ([209.85.192.193]:35594 "EHLO
	mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750756AbcHDGN7 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Aug 2016 02:13:59 -0400
Date: Thu, 4 Aug 2016 14:04:57 +0800
From: Peter Chen <hzpeterchen@gmail.com>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Peter Chen <peter.chen@nxp.com>, gregkh@linuxfoundation.org,
        stern@rowland.harvard.edu, ulf.hansson@linaro.org, broonie@kernel.org,
        sre@kernel.org, robh+dt@kernel.org, shawnguo@kernel.org,
        dbaryshkov@gmail.com, dwmw3@infradead.org, k.kozlowski@samsung.com,
        linux-arm-kernel@lists.infradead.org, p.zabel@pengutronix.de,
        devicetree@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        linux-usb@vger.kernel.org, arnd@arndb.de, s.hauer@pengutronix.de,
        mail@maciej.szmigiero.name, troy.kisky@boundarydevices.com,
        festevam@gmail.com, oscar@naiandei.net, stephen.boyd@linaro.org,
        linux-pm@vger.kernel.org, stillcompiling@gmail.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/6] power: add power sequence library
Message-ID: <20160804060457.GA27272@shlinux2>
References: <1470108652-16812-1-git-send-email-peter.chen@nxp.com>
 <1470108652-16812-3-git-send-email-peter.chen@nxp.com>
 <20160803221658.GD1405@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160803221658.GD1405@google.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 03, 2016 at 03:16:58PM -0700, Matthias Kaehlcke wrote:
> El Tue, Aug 02, 2016 at 11:30:48AM +0800 Peter Chen ha dit:
> 
> > diff --git a/drivers/power/pwrseq/core.c b/drivers/power/pwrseq/core.c
> >
> > ...
> >
> > +static DEFINE_MUTEX(pwrseq_list_mutex);
> > +static LIST_HEAD(pwrseq_list);
> > +
> > +int pwrseq_get(struct device_node *np, struct pwrseq *p)
> > +{
> > +	if (p && p->get)
> > +		return p->get(np, p);
> > +
> > +	return -ENOTSUPP;
> > +}
> > +
> > +int pwrseq_on(struct device_node *np, struct pwrseq *p)
> > +{
> > +	if (p && p->on)
> > +		return p->on(np, p);
> > +
> > +	return -ENOTSUPP;
> > +}
> > +
> > +void pwrseq_off(struct pwrseq *p)
> > +{
> > +	if (p && p->off)
> > +		p->off(p);
> > +}
> > +
> > +void pwrseq_put(struct pwrseq *p)
> > +{
> > +	if (p && p->put)
> > +		p->put(p);
> > +}
> > +
> > +void pwrseq_free(struct pwrseq *p)
> > +{
> > +	if (p && p->free)
> > +		p->free(p);
> > +}
> > +
> > +void pwrseq_register(struct pwrseq *pwrseq)
> > +{
> > +	mutex_lock(&pwrseq_list_mutex);
> > +	list_add(&pwrseq->node, &pwrseq_list);
> > +	mutex_unlock(&pwrseq_list_mutex);
> > +}
> > +
> > +void pwrseq_unregister(struct pwrseq *pwrseq)
> > +{
> > +	mutex_lock(&pwrseq_list_mutex);
> > +	list_del(&pwrseq->node);
> > +	mutex_unlock(&pwrseq_list_mutex);
> > +}
> 
> What is the purpose of pwrseq_register/unregister()? The pwrseq
> structs are added and removed from pwrseq_list, but besides that
> pwrseq_list is not used.
> 

I had thought we may need to dump the pwrseq list in future for debug
purpose. I will delete this unnecessary code.

-- 

Best Regards,
Peter Chen