From: Mel Gorman <mgorman@techsingularity.net>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [bug, 4.8] /proc/meminfo: counter values are very wrong
Date: Thu, 4 Aug 2016 13:24:09 +0100 [thread overview]
Message-ID: <20160804122409.GK2799@techsingularity.net> (raw)
In-Reply-To: <20160804051051.GS12670@dastard>
On Thu, Aug 04, 2016 at 03:10:51PM +1000, Dave Chinner wrote:
> Hi folks,
>
> I just noticed a whacky memory usage profile when running some basic
> IO tests on a current 4.8 tree. It looked like there was a massive
> memory leak from my monitoring graphs - doing buffered IO was
> causing huge amounts of memory to be considered used, but the cache
> size was not increasing.
>
> Looking at /proc/meminfo:
>
> $ cat /proc/meminfo
> MemTotal: 16395408 kB
> MemFree: 79424 kB
> MemAvailable: 2497240 kB
> Buffers: 4372 kB
> Cached: 558744 kB
> SwapCached: 48 kB
> Active: 2127212 kB
> Inactive: 100400 kB
> Active(anon): 25348 kB
> Inactive(anon): 79424 kB
> Active(file): 2101864 kB
> Inactive(file): 20976 kB
> Unevictable: 13612980 kB <<<<<<<<<
This? Very quickly done, no boot testing
diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
index 09e18fdf61e5..b9a8c813e5e6 100644
--- a/fs/proc/meminfo.c
+++ b/fs/proc/meminfo.c
@@ -46,7 +46,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
cached = 0;
for (lru = LRU_BASE; lru < NR_LRU_LISTS; lru++)
- pages[lru] = global_page_state(NR_LRU_BASE + lru);
+ pages[lru] = global_node_page_state(NR_LRU_BASE + lru);
available = si_mem_available();
next prev parent reply other threads:[~2016-08-04 12:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 5:10 [bug, 4.8] /proc/meminfo: counter values are very wrong Dave Chinner
2016-08-04 12:24 ` Mel Gorman [this message]
2016-08-04 12:34 ` Mel Gorman
2016-08-04 23:11 ` Dave Chinner
2016-08-05 10:54 ` Mel Gorman
2016-08-05 11:59 ` Dave Chinner
2016-08-05 12:07 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804122409.GK2799@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox