From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933471AbcHDNBE (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Aug 2016 09:01:04 -0400
Received: from mga04.intel.com ([192.55.52.120]:22833 "EHLO mga04.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1758601AbcHDNBD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Aug 2016 09:01:03 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.28,470,1464678000"; 
   d="scan'208";a="1019587686"
Date: Thu, 4 Aug 2016 18:38:34 +0530
From: Vinod Koul <vinod.koul@intel.com>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>, Andy Green <andy.green@linaro.org>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Jingoo Han <jg1.han@samsung.com>,
        Krzysztof Kozlowski <k.kozlowski@samsung.com>,
        Maxime Ripard <maxime.ripard@free-electrons.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Mark Brown <broonie@kernel.org>, Andy Green <andy@warmcat.com>
Subject: Re: [PATCH 1/7] k3dma: Fix hisi burst clipping
Message-ID: <20160804130833.GI9681@localhost>
References: <1469073189-9167-1-git-send-email-john.stultz@linaro.org>
 <1469073189-9167-2-git-send-email-john.stultz@linaro.org>
 <20160724072509.GC9681@localhost>
 <CALAqxLUvvGgn=2HugJQH=__FQsjgXcCDv9xRYz=h8sX3rCDS_w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALAqxLUvvGgn=2HugJQH=__FQsjgXcCDv9xRYz=h8sX3rCDS_w@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jul 29, 2016 at 03:40:46PM -0700, John Stultz wrote:
> On Sun, Jul 24, 2016 at 12:25 AM, Vinod Koul <vinod.koul@intel.com> wrote:
> > On Wed, Jul 20, 2016 at 08:53:03PM -0700, John Stultz wrote:
> >> From: Andy Green <andy.green@linaro.org>
> >>
> >> Max burst len is a 4-bit field, but at the moment it's clipped with
> >> a 5-bit constant... reduce it to that which can be expressed
> >
> > Maybe we should GENMASK() etc to avoid these errors..
> 
> Not sure I follow what you're thinking here... can you clarify a bit?

I am assuming the 4bit field was a mistake by orignal author. Using GENMASK,
BIT etc macro helps you to avoid those as one would look at datasheet and
say this is specfied as bit 5 thru 9, so let me say GENMASK(5, 0) rather
than a typo which missed 5th bit.

But ofcourse if the error was due to some other reason then this one doesnt
help.

-- 
~Vinod