The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Mike Galbraith <efault@gmx.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@01.org
Subject: Re: [lkp] [sched/fair]  e210bffd39: perf-stat.cpu-migrations -36.0% decrease
Date: Thu, 4 Aug 2016 21:57:59 +0800	[thread overview]
Message-ID: <20160804135759.GA9114@yexl-desktop> (raw)
In-Reply-To: <20160804090124.GK6879@twins.programming.kicks-ass.net>

On 08/04, Peter Zijlstra wrote:
>On Thu, Aug 04, 2016 at 01:24:23PM +0800, kernel test robot wrote:
>> 
>> FYI, we noticed perf-stat.cpu-migrations -36.0% decrease due to commit:
>> 
>> commit e210bffd39d01b649c94b820c28ff112673266dd ("sched/fair: Fix and optimize the fork() path")
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> 
>> in testcase: unixbench
>> on test machine: 16 threads Broadwell-DE with 8G memory
>> with following parameters:
>> 
>> 	runtime: 300s
>> 	nr_task: 1
>> 	test: shell8
>> 	cpufreq_governor: performance
>> 
>> 
>
>Urgh, I so hate these reports. They're near useless :/
>
>It took me 3 readings to realize it was the unixbench testcase (why
>isn't that in the subject!?). But then I still haven't found the primary

Will add test name in subject in later performance reports.

>performance metric. Does the test improve, degrade or not change
>overall?
>
Sorry, I should have described it more clearly, the primary performance
metric of unixbench is not changed, while perf-stat.cpu-migrations has a
-36.0% decrease which should improve cache locality.

We'd expect such stats changes report would help the developer to
evaluate impacts of his patch, anyway, we'll make it more clear that
it's just a FYI report, not some regression report. 

Thanks,
Xiaolong

>

      parent reply	other threads:[~2016-08-04 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-04  5:24 [lkp] [sched/fair] e210bffd39: perf-stat.cpu-migrations -36.0% decrease kernel test robot
2016-08-04  9:01 ` Peter Zijlstra
2016-08-04  9:05   ` Vincent Guittot
2016-08-04 13:57   ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804135759.GA9114@yexl-desktop \
    --to=xiaolong.ye@intel.com \
    --cc=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox