From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933993AbcHDOK6 (ORCPT ); Thu, 4 Aug 2016 10:10:58 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:47306 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758659AbcHDOK3 (ORCPT ); Thu, 4 Aug 2016 10:10:29 -0400 Date: Thu, 4 Aug 2016 16:05:26 +0200 From: Ralf Baechle To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, James Hartley , Ionela Voinescu , linux-mips@linux-mips.org Subject: Re: [PATCH] MIPS: dont specify STACKPROTECTOR in defconfigs Message-ID: <20160804140526.GA23195@linux-mips.org> References: <20160803190359.6486-1-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160803190359.6486-1-paul.gortmaker@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 03, 2016 at 03:03:59PM -0400, Paul Gortmaker wrote: > Only one defconfig has a STACKPROTECTOR value. And it asks for > the strong variant, which isn't supported by older toolchains. > > Due to the nature of MIPS having more platform specific code than say > x86, the allyesconfig and allmodconfig aren't as effective for build > coverage. So, in addition, I like to use a trivial script to walk all > the defconfigs and build each one. > > However I will get false positives on unsupported stackprotector values > with an older toolchain like gcc-4.6.3. As in this instance I am just > using the compiler as a glorified syntax checker on a machine where I > build a bunch of other arch for the same reason, there is no real > motivation to get a newer toolchain for improved optimization etc. > > Since there is only one of them, and there is nothing about these > settings that are board/platform specific, I propose we just eliminate > the existing instance and take the default. Yeah, I can see how that one may get annoying. I wish there was something along the lines of KCONFIG_ALLCONFIG that was working not only for allyesconfig/allmodconfig/allnoconfig/randconfig. Applied. Thanks, Ralf