From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964926AbcHDPUL (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Aug 2016 11:20:11 -0400
Received: from mail-pa0-f68.google.com ([209.85.220.68]:36104 "EHLO
	mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933685AbcHDPUJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Aug 2016 11:20:09 -0400
Date: Thu, 4 Aug 2016 08:20:05 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mika =?iso-8859-1?Q?Penttil=E4?= <mika.penttila@nextfour.com>,
        Tammy Tseng <tammy_tseng@sis.com>, Yuger Yu <yuger_yu@sis.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: sis-i2c: select CONFIG_CRC_ITU_T
Message-ID: <20160804152005.GA5504@dtor-ws>
References: <20160804130758.1253722-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160804130758.1253722-1-arnd@arndb.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 04, 2016 at 03:07:06PM +0200, Arnd Bergmann wrote:
> The newly added sis_i2c driver fails to link without the CRC_ITU_T
> driver enabled:
> 
> drivers/input/touchscreen/sis_i2c.o: In function `sis_ts_irq_handler':
> sis_i2c.c:(.text+0xc0): undefined reference to `crc_itu_t'
> 
> This adds a Kconfig select statement.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: a485cb037fe6 ("Input: add driver for SiS 9200 family I2C touchscreen controllers")

Thank you Arnd.

> ---
>  drivers/input/touchscreen/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> index 8d893cefb0e3..2fb1f430a431 100644
> --- a/drivers/input/touchscreen/Kconfig
> +++ b/drivers/input/touchscreen/Kconfig
> @@ -1074,6 +1074,7 @@ config TOUCHSCREEN_SILEAD
>  config TOUCHSCREEN_SIS_I2C
>  	tristate "SiS 9200 family I2C touchscreen"
>  	depends on I2C
> +	select CRC_ITU_T
>  	depends on GPIOLIB || COMPILE_TEST
>  	help
>  	  This enables support for SiS 9200 family over I2C based touchscreens.
> -- 
> 2.9.0
> 

-- 
Dmitry