public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Nikolay Borisov <kernel@kyup.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	andi@firstfloor.org
Subject: Re: Strange behavior of perf top with PEBS
Date: Thu, 4 Aug 2016 17:29:26 +0200	[thread overview]
Message-ID: <20160804152926.GA25592@krava> (raw)
In-Reply-To: <579749E6.1030408@kyup.com>

On Tue, Jul 26, 2016 at 02:30:46PM +0300, Nikolay Borisov wrote:
> 
> 
> On 07/20/2016 05:38 PM, Jiri Olsa wrote:
> > On Wed, Jul 20, 2016 at 04:34:17PM +0200, Jiri Olsa wrote:
> >> On Wed, Jul 20, 2016 at 04:28:34PM +0300, Nikolay Borisov wrote:
> >>> Hello,
> >>>
> >>> Running perf version 4.4.14.g0cb188d (no modification to the PMU/perf
> >>> code) I observed that "perf top" counts no cycles and produces no
> >>> output. After a bit of head scratching and testing I figured that
> >>> running "perf top -e cycles" actually works whereas the default option
> >>> is equivalent to running "perf top -e cycles:p". So the latter version
> >>> seems to not work on my machine.
> >>
> >> hum, I think Core2 has PEBs valid only for instructions not cycles..
> >>
> >> I'll check why perf top forcing the precise for cycles
> >> I thought we had that automated already
> > 
> > oops, too soon ;) we have:
> > 
> > perf/x86/intel: Fix Core2,Atom,NHM,WSM cycles:pp events
> > commit 517e6341fa123ec3a2f9ea78ad547be910529881
> > Author: Peter Zijlstra <peterz@infradead.org>
> > Date:   Sat Apr 11 12:16:22 2015 +0200
> > 
> > 
> > so i guess it should work.. checking ;-)
> 
> Any update on that?

sorry for late response..

I checked on f22 kernel and it's missing the core2 PEBs fix:
  1424a09a9e18 perf/x86: fix PEBS issues on Intel Atom/Core2

which was introduced in 4.5.. you should upgrade or include
this patch

jirka

  reply	other threads:[~2016-08-04 15:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-20 13:28 Strange behavior of perf top with PEBS Nikolay Borisov
2016-07-20 14:34 ` Jiri Olsa
2016-07-20 14:36   ` Nikolay Borisov
2016-07-20 14:38   ` Jiri Olsa
2016-07-26 11:30     ` Nikolay Borisov
2016-08-04 15:29       ` Jiri Olsa [this message]
2016-08-05  9:30         ` Nikolay Borisov
2016-08-05 10:23           ` Jiri Olsa
2016-08-08 13:03             ` Peter Zijlstra
2016-08-08 13:19               ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160804152926.GA25592@krava \
    --to=jolsa@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=kernel@kyup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox