From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965836AbcHEA5v (ORCPT ); Thu, 4 Aug 2016 20:57:51 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53728 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964849AbcHEA5t (ORCPT ); Thu, 4 Aug 2016 20:57:49 -0400 Date: Thu, 4 Aug 2016 17:57:48 -0700 From: Stephen Boyd To: Andy Gross Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson Subject: Re: [PATCH 2/3] regulator: qcom_smd: Fix voltage ranges for pma8084 ftsmps and pldo Message-ID: <20160805005748.GC15690@codeaurora.org> References: <20160711215009.4519-1-sboyd@codeaurora.org> <20160711215009.4519-3-sboyd@codeaurora.org> <20160711223827.GA6053@hector.attlocal.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160711223827.GA6053@hector.attlocal.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11, Andy Gross wrote: > On Mon, Jul 11, 2016 at 02:50:08PM -0700, Stephen Boyd wrote: > > The voltage ranges listed here are wrong. The pma8084 pldo > > supports three different overlapping voltage ranges with > > differing step sizes and the pma8084 ftsmps supports two. These > > ranges can be seen in the "native" spmi regulator driver > > (qcom_spmi-regulator.c) at pldo_ranges[] and ftsmps_ranges[] > > respectively. Port these ranges over to the RPM SMD regulator > > driver so that we list the appropriate set of supported voltages > > on these types of regulators. > > > > Cc: Andy Gross > > Cc: Bjorn Andersson > > Fixes: ee01d0c91ef1 ("regulator: qcom-smd: Add support for PMA8084") > > Signed-off-by: Stephen Boyd > > > > > static const struct regulator_desc pma8084_pldo = { > > .linear_ranges = (struct regulator_linear_range[]) { > > - REGULATOR_LINEAR_RANGE(750000, 0, 30, 25000), > > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000), > > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500), > > It was my understanding that the PMOS ldos only support 25mV and 50mV > incremements. > Unfortunately that isn't true. It also supports 12.5mV steps for the lower voltage ranges. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project