From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966071AbcHEA6b (ORCPT ); Thu, 4 Aug 2016 20:58:31 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53784 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964849AbcHEA62 (ORCPT ); Thu, 4 Aug 2016 20:58:28 -0400 Date: Thu, 4 Aug 2016 17:58:26 -0700 From: Stephen Boyd To: Andy Gross Cc: Mark Brown , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson Subject: Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Message-ID: <20160805005826.GD15690@codeaurora.org> References: <20160711215009.4519-1-sboyd@codeaurora.org> <20160711215009.4519-2-sboyd@codeaurora.org> <20160711224845.GC6053@hector.attlocal.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160711224845.GC6053@hector.attlocal.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11, Andy Gross wrote: > On Mon, Jul 11, 2016 at 02:50:07PM -0700, Stephen Boyd wrote: > > > static const struct regulator_desc pm8941_pldo = { > > .linear_ranges = (struct regulator_linear_range[]) { > > - REGULATOR_LINEAR_RANGE( 750000, 0, 30, 25000), > > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000), > > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500), > > + REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000), > > + REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000), > > }, > > - .n_linear_ranges = 2, > > - .n_voltages = 100, > > + .n_linear_ranges = 3, > > + .n_voltages = 164, > > .ops = &rpm_smps_ldo_ops, > > }; > > Still a little confused on if the 12.5mV is allowed on pmos ldo. It seems like the > nmos has 1 range of 5mV steps. The PMOS has 2 ranges, using 25mV and 50mV > The values I've put in these patches are the correct ranges. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project