From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161084AbcHEHBv (ORCPT ); Fri, 5 Aug 2016 03:01:51 -0400 Received: from mail.skyhub.de ([78.46.96.112]:59851 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161066AbcHEHBr (ORCPT ); Fri, 5 Aug 2016 03:01:47 -0400 Date: Fri, 5 Aug 2016 09:01:26 +0200 From: Borislav Petkov To: york sun , Johannes Thumshirn Cc: Michael Ellerman , "linux-edac@vger.kernel.org" , "morbidrsa@gmail.com" , "oss@buserror.net" , Stuart Yoder , Benjamin Herrenschmidt , Paul Mackerras , Kevin Hao , Andrew Donnellan , Yinghai Lu , Bjorn Helgaas , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac Message-ID: <20160805070126.GE25630@nazgul.tnic> References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-2-git-send-email-york.sun@nxp.com> <877fbvkhi3.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2016 at 04:26:26AM +0000, york sun wrote: > I don't have deep knowledge of this driver. What I am trying is to > separate the common DDR part and share it with ARM platforms. Along the > way, I found the compiling error if build a module. If exposing these > functions becomes a concern, I can live without it. Perhaps you or Johannes could fix this properly to use pci_get_device() as the rest of the EDAC drivers do, instead of exporting core PCI functions... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --