From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759514AbcHEHxw (ORCPT ); Fri, 5 Aug 2016 03:53:52 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:33819 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752961AbcHEHxt (ORCPT ); Fri, 5 Aug 2016 03:53:49 -0400 Date: Fri, 5 Aug 2016 08:55:11 +0100 From: Lee Jones To: SF Markus Elfring Cc: kernel-janitors@vger.kernel.org, Linux Kernel Mailing List , Julia Lawall Subject: Re: [PATCH v4] mfd: dm355evm_msp: Refactoring for add_child() Message-ID: <20160805075511.GN5243@dell> References: <4dcb4cab-e2cc-87c0-9cfc-d140f185254b@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4dcb4cab-e2cc-87c0-9cfc-d140f185254b@users.sourceforge.net> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 01 Jul 2016, SF Markus Elfring wrote: > From: Markus Elfring Please use `git send-email` to submit your patches. > Adjust jump targets according to the Linux coding style convention. > Another check for the variable "status" can be omitted then at the end. > > Signed-off-by: Markus Elfring > --- > v4: Further feedback was integrated into this message. This is not a good change-log. What actually changed? > v3: Deletion of another blank line > v2: Rebasing > > drivers/mfd/dm355evm_msp.c | 17 +++++++++-------- > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/mfd/dm355evm_msp.c b/drivers/mfd/dm355evm_msp.c > index 270e19c..86eca61 100644 > --- a/drivers/mfd/dm355evm_msp.c > +++ b/drivers/mfd/dm355evm_msp.c > @@ -209,7 +209,7 @@ static struct device *add_child(struct i2c_client *client, const char *name, > status = platform_device_add_data(pdev, pdata, pdata_len); > if (status < 0) { > dev_dbg(&pdev->dev, "can't add platform_data\n"); Please take the opportunity to convert these to dev_err()s. > - goto err; > + goto put_device; > } > } > > @@ -222,19 +222,20 @@ static struct device *add_child(struct i2c_client *client, const char *name, > status = platform_device_add_resources(pdev, &r, 1); > if (status < 0) { > dev_dbg(&pdev->dev, "can't add irq\n"); > - goto err; > + goto put_device; > } > } > > status = platform_device_add(pdev); > + if (status) > + goto put_device; > > -err: > - if (status < 0) { > - platform_device_put(pdev); > - dev_err(&client->dev, "can't add %s dev\n", name); > - return ERR_PTR(status); > - } > return &pdev->dev; > + > +put_device: > + platform_device_put(pdev); > + dev_err(&client->dev, "failed to add device %s\n", name); ... and remove this line. > + return ERR_PTR(status); > } > > static int add_children(struct i2c_client *client) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog