From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759621AbcHEKOO (ORCPT ); Fri, 5 Aug 2016 06:14:14 -0400 Received: from foss.arm.com ([217.140.101.70]:55718 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759483AbcHEKON (ORCPT ); Fri, 5 Aug 2016 06:14:13 -0400 Date: Fri, 5 Aug 2016 11:13:14 +0100 From: Juri Lelli To: xlpang@redhat.com Cc: peterz@infradead.org, rostedt@goodmis.org, linux-kernel@vger.kernel.org, mingo@redhat.com, luca.abeni@unitn.it Subject: Re: [PATCH v4] sched/deadline: remove useless param from setup_new_dl_entity Message-ID: <20160805101314.GD28125@e106622-lin> References: <1468407489-30476-1-git-send-email-juri.lelli@arm.com> <5788BD67.5050509@redhat.com> <20160718130441.GH30141@e106622-lin> <578CDB83.1030702@redhat.com> <20160721142106.GH30584@e106622-lin> <20160721143645.GI30584@e106622-lin> <20160721144614.GJ30584@e106622-lin> <57918BEF.2090400@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57918BEF.2090400@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/16 10:58, Xunlei Pang wrote: > On 2016/07/21 at 22:46, Juri Lelli wrote: [...] > > @@ -1734,9 +1724,11 @@ static void switched_to_dl(struct rq *rq, struct task_struct *p) > > if (task_on_rq_queued(p)) { > > /* > > * If p is not queued we will update its parameters at next > > - * wakeup. > > + * wakeup. If p is dl_boosted we already updated its params in > > + * rt_mutex_setprio()->enqueue_task(..., ENQUEUE_REPLENISH). > > */ > > - if (dl_time_before(p->dl.deadline, rq_clock(rq))) > > + if (dl_time_before(p->dl.deadline, rq_clock(rq)) && > > + !p->dl.dl_boosted) > > Hi Juri, > > It looks good to me, only one question: > For on_rq boosted to deadline, p->dl.deadline has been updated after rq_lock(rq) by > rt_mutex_setprio()->enqueue_task(..., ENQUEUE_REPLENISH) and no rq clock update > afterwards, so dl_time_before() will be false, seems p->dl.dl_boosted check is needless. > Right. I removed it and posted v5. Please have a look. Best, - Juri