From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759900AbcHEOyO (ORCPT ); Fri, 5 Aug 2016 10:54:14 -0400 Received: from smtprelay0022.hostedemail.com ([216.40.44.22]:49072 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759759AbcHEOyN (ORCPT ); Fri, 5 Aug 2016 10:54:13 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:2895:3138:3139:3140:3141:3142:3352:3622:3867:3868:3871:3873:3874:4362:5007:6261:7875:7903:7904:9040:10004:10400:10848:10967:11026:11232:11658:11914:12043:12296:12517:12519:12740:13069:13311:13357:13439:14181:14659:14721:21080:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: start94_7bb7a6de0af16 X-Filterd-Recvd-Size: 2069 Date: Fri, 5 Aug 2016 10:54:08 -0400 From: Steven Rostedt To: Juri Lelli Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, mingo@redhat.com, luca.abeni@unitn.it, xpang@redhat.com Subject: Re: [PATCH v5] sched/deadline: remove useless param from setup_new_dl_entity Message-ID: <20160805105408.3780d599@gandalf.local.home> In-Reply-To: <20160805143444.GH28125@e106622-lin> References: <1470391799-22939-1-git-send-email-juri.lelli@arm.com> <20160805095643.130194cf@gandalf.local.home> <20160805143444.GH28125@e106622-lin> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Aug 2016 15:34:44 +0100 Juri Lelli wrote: > On 05/08/16 09:56, Steven Rostedt wrote: > > On Fri, 5 Aug 2016 11:09:59 +0100 > > Juri Lelli wrote: > > > > > @@ -1720,19 +1720,28 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p) > > > */ > > > static void switched_to_dl(struct rq *rq, struct task_struct *p) > > > { > > > - if (dl_time_before(p->dl.deadline, rq_clock(rq))) > > > - setup_new_dl_entity(&p->dl, &p->dl); > > > > > > - if (task_on_rq_queued(p) && rq->curr != p) { > > > + if (task_on_rq_queued(p)) { > > > > I always hated functions totally encapsulated by an if statement. This > > can be a bit simpler (and less indented) if you have: > > > > /* If p is not queued, its parameters will be updated at wakeup */ > > if (!task_on_rq_queued(p)) > > return; > > > > [...] > > > > You mean like what follows? > > I'll post a v6 if OK. > Yes! I think that looks much nicer, and easier to read. You can add my Reviewed-by tag too. Thanks! -- Steve