From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935022AbcHEL7k (ORCPT ); Fri, 5 Aug 2016 07:59:40 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:63582 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934333AbcHEL7j (ORCPT ); Fri, 5 Aug 2016 07:59:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArcPAG9+pFd5LI7JIGdsb2JhbABcg0WBUoZynS8BAQEBAQEGjGGKG4YXBAICgUhNAQEBAQEBBwEBAQEBAThAhF8BBScTHCMQCAMOCgklDwUlAwcaE4gwvkMBAQEHAiUehUSFFYobBZk1jn6PTIwzg3eCZhyBXioyh2UBAQE Date: Fri, 5 Aug 2016 21:59:35 +1000 From: Dave Chinner To: Mel Gorman Cc: linux-kernel@vger.kernel.org Subject: Re: [bug, 4.8] /proc/meminfo: counter values are very wrong Message-ID: <20160805115935.GI16044@dastard> References: <20160804051051.GS12670@dastard> <20160804122409.GK2799@techsingularity.net> <20160804123458.GL2799@techsingularity.net> <20160804231110.GU12670@dastard> <20160805105417.GQ2799@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160805105417.GQ2799@techsingularity.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2016 at 11:54:17AM +0100, Mel Gorman wrote: > On Fri, Aug 05, 2016 at 09:11:10AM +1000, Dave Chinner wrote: > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > > index fb975cec3518..baa97da3687d 100644 > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -4064,7 +4064,7 @@ long si_mem_available(void) > > > int lru; > > > > > > for (lru = LRU_BASE; lru < NR_LRU_LISTS; lru++) > > > - pages[lru] = global_page_state(NR_LRU_BASE + lru); > > > + pages[lru] = global_node_page_state(NR_LRU_BASE + lru); > > > > > > for_each_zone(zone) > > > wmark_low += zone->watermark[WMARK_LOW]; > > > > OK, that makes the /proc accounting match the /sys per-node > > accounting, but the output still looks wrong. I remove files with > > cached pages from the filesystem (i.e. invalidate and free them), > > yet they are apparrently still accounted as being on the > > active/inactive LRU. > > > > Reboot, then run dbench for a minute: > > > > $ sudo mkfs.xfs -f /dev/pmem1 > > meta-data=/dev/pmem1 isize=512 agcount=4, agsize=524288 blks > > = sectsz=4096 attr=2, projid32bit=1 > > = crc=1 finobt=1, sparse=0 > > data = bsize=4096 blocks=2097152, imaxpct=25 > > = sunit=0 swidth=0 blks > > naming =version 2 bsize=4096 ascii-ci=0 ftype=1 > > log =internal log bsize=4096 blocks=2560, version=2 > > = sectsz=4096 sunit=1 blks, lazy-count=1 > > realtime =none extsz=4096 blocks=0, rtextents=0 > > $ sudo mount /dev/pmem1 /mnt/scratch > > $ sudo dbench -t 60 -D /mnt/scratch/ 16 > > dbench version 4.00 - Copyright Andrew Tridgell 1999-2004 > > > > Is there any chance this is related to pmem1? Nope, just reproduced it on /dev/vdc to confirm. Cheers, Dave. -- Dave Chinner david@fromorbit.com