From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935043AbcHEMyo (ORCPT ); Fri, 5 Aug 2016 08:54:44 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37415 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759654AbcHEMyn (ORCPT ); Fri, 5 Aug 2016 08:54:43 -0400 Date: Fri, 5 Aug 2016 13:56:07 +0100 From: Lee Jones To: Paul Gortmaker Cc: Laxman Dewangan , linux-kernel@vger.kernel.org, Samuel Ortiz , Florian Lobmaier Subject: Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular Message-ID: <20160805125607.GZ5243@dell> References: <20160705012544.14143-1-paul.gortmaker@windriver.com> <20160705012544.14143-3-paul.gortmaker@windriver.com> <577B4A30.4050303@nvidia.com> <20160706164538.GI26134@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160706164538.GI26134@windriver.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Jul 2016, Paul Gortmaker wrote: > [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 (Tue 11:18) Laxman Dewangan wrote: > > > > > On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote: > > >The Kconfig currently controlling compilation of this code is: > > > > > >drivers/mfd/Kconfig:config MFD_AS3722 > > >drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC" > > > > > > > > > Should we convert this to as "tristate" so that it can be built as module > > also. > > Seems to compile and modpost w/o missing symbols as tristate: > > paul@yow-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722* > -rw-rw-r-- 1 paul paul 13010 Jul 6 12:30 ../arm-build/drivers/mfd/as3722.ko > -rw-rw-r-- 1 paul paul 1937 Jul 6 12:28 ../arm-build/drivers/mfd/as3722.mod.c > -rw-rw-r-- 1 paul paul 3820 Jul 6 12:29 ../arm-build/drivers/mfd/as3722.mod.o > -rw-rw-r-- 1 paul paul 11292 Jul 6 12:13 ../arm-build/drivers/mfd/as3722.o > paul@yow-builder:~/git/linux-head$ > > ...so I'll drop this patch in favour of the one line tristate conversion in v2. Did you ever get around to submitting a v2? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog