Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular

Paul Gortmaker
2016-07-06T16:38:07Z

[Re: [PATCH 3/6] mfd: intel_msic: Make it explicitly non-modular] On 05/07/2016 (Tue 13:08) Mika Westerberg wrote:

> On Mon, Jul 04, 2016 at 09:25:41PM -0400, Paul Gortmaker wrote:
> > The Kconfig currently controlling compilation of this code is:
> >
> > drivers/mfd/Kconfig:config MFD_INTEL_MSIC
> > drivers/mfd/Kconfig: bool "Intel MSIC"
>
> I would prefer if it could be turned to tristate instead. I don't see
> any reasons why it should only be builtin.

If I change it to tristate, it is still impossible to choose =m for it
unless I revert your earlier commit forcing it to be built in.

commit 15a713df4145ad2540f8d84c3f4de930806f6151
Author: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Thu Jan 26 17:35:05 2012 +0000

x86/config: Select MSIC MFD driver on Intel Medfield platform

On Intel Medfield platform we use MSIC MFD driver to create
necessary platform devices so it is essential to have the driver
compiled into the kernel.

If I revert that, then it is possible to choose =m and it compiles.
(haven't completed modpost yet.. so may be missing symbols...)

Paul.
--