Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular

Lee Jones
2016-08-05T12:54:44Z

On Wed, 06 Jul 2016, Paul Gortmaker wrote:

> [Re: [PATCH 2/6] mfd: as3722: Make it explicitly non-modular] On 05/07/2016 (Tue 11:18) Laxman Dewangan wrote:
>
> >
> > On Tuesday 05 July 2016 06:55 AM, Paul Gortmaker wrote:
> > >The Kconfig currently controlling compilation of this code is:
> > >
> > >drivers/mfd/Kconfig:config MFD_AS3722
> > >drivers/mfd/Kconfig: bool "ams AS3722 Power Management IC"
> > >
> >
> >
> > Should we convert this to as "tristate" so that it can be built as module
> > also.
>
> Seems to compile and modpost w/o missing symbols as tristate:
>
> paul@yow-builder:~/git/linux-head$ ls -l ../arm-build/drivers/mfd/as3722*
> -rw-rw-r-- 1 paul paul 13010 Jul 6 12:30 ../arm-build/drivers/mfd/as3722.ko
> -rw-rw-r-- 1 paul paul 1937 Jul 6 12:28 ../arm-build/drivers/mfd/as3722.mod.c
> -rw-rw-r-- 1 paul paul 3820 Jul 6 12:29 ../arm-build/drivers/mfd/as3722.mod.o
> -rw-rw-r-- 1 paul paul 11292 Jul 6 12:13 ../arm-build/drivers/mfd/as3722.o
> paul@yow-builder:~/git/linux-head$
>
> ...so I'll drop this patch in favour of the one line tristate conversion in v2.

Did you ever get around to submitting a v2?

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog