From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC 0/4] tools lib traceevent: Install fixes
Date: Fri, 5 Aug 2016 11:42:41 -0300 [thread overview]
Message-ID: <20160805144241.GP14639@kernel.org> (raw)
In-Reply-To: <20160805101352.6bc16cdf@gandalf.local.home>
Em Fri, Aug 05, 2016 at 10:13:52AM -0400, Steven Rostedt escreveu:
> On Tue, 2 Aug 2016 16:01:44 +0200
> Jiri Olsa <jolsa@redhat.com> wrote:
> > > BTW, before we start making this ready for their own libraries, I'd
> > > like to make some changes with the naming convention. Mainly with
> > > event_format and format_field.
> > >
> > > Perhaps we should change them to pevent_event and pevent_field?
> >
> > right, it does not have any global prefix for public symbols
> >
> > I'd actualy expect something like 'traceevent_',
> > but 'pevent' is ok as well I guess
>
> OK, what's the consensus here? Should we keep "pevent_" or switch to
> the longer "traceevent_"?
traceevent_ matches libtraceevent, so I think would be more obvious the
association of code with the library.
- Arnaldo
> I want to make the patch that gets this ready to ship!
>
> -- Steve
next prev parent reply other threads:[~2016-08-05 14:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 17:41 [RFC 0/4] tools lib traceevent: Install fixes Jiri Olsa
2016-08-01 17:41 ` [PATCH 1/4] tools lib traceevent: Add install_headers target Jiri Olsa
2016-08-02 2:19 ` Namhyung Kim
2016-08-02 9:30 ` Jiri Olsa
2016-08-01 17:41 ` [PATCH 2/4] tools lib traceevent: Add do_install_mkdir Makefile function Jiri Olsa
2016-08-01 17:41 ` [PATCH 3/4] tools lib traceevent: Rename LIB_FILE to LIB_TARGET Jiri Olsa
2016-08-01 17:41 ` [PATCH 4/4] tools lib traceevent: Add version for traceevent shared object Jiri Olsa
2016-08-02 3:10 ` [RFC 0/4] tools lib traceevent: Install fixes Namhyung Kim
2016-08-02 5:01 ` [PATCH 1/2] tools lib traceevent: Ignore generated library files Namhyung Kim
2016-08-02 5:01 ` [PATCH 2/2] tools lib traceevent: Add str_error_r() Namhyung Kim
2016-08-02 14:27 ` Namhyung Kim
2016-08-04 9:10 ` [tip:perf/urgent] tools lib traceevent: Ignore generated library files tip-bot for Namhyung Kim
2016-08-02 9:31 ` [RFC 0/4] tools lib traceevent: Install fixes Jiri Olsa
2016-08-02 13:48 ` Steven Rostedt
2016-08-02 14:01 ` Jiri Olsa
2016-08-02 14:14 ` Namhyung Kim
2016-08-02 14:18 ` Arnaldo Carvalho de Melo
2016-08-02 14:16 ` Steven Rostedt
2016-08-05 14:13 ` Steven Rostedt
2016-08-05 14:42 ` Arnaldo Carvalho de Melo [this message]
2016-08-07 12:56 ` Jiri Olsa
2018-01-19 10:37 ` Jiri Olsa
2018-01-19 15:07 ` Steven Rostedt
2018-01-19 15:15 ` Jiri Olsa
2018-01-26 6:04 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805144241.GP14639@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).