From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752057AbcHFUgM (ORCPT ); Sat, 6 Aug 2016 16:36:12 -0400 Received: from mail.kernel.org ([198.145.29.136]:50248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969AbcHFUgK (ORCPT ); Sat, 6 Aug 2016 16:36:10 -0400 Date: Sat, 6 Aug 2016 19:30:45 +0900 From: Masami Hiramatsu To: Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: Re: [PATCH v2] perf probe: fix module name matching Message-Id: <20160806193045.d12c57e9f6bf32db719cd773@kernel.org> In-Reply-To: <147039975648.715620.12985971832789032159.stgit@buzz> References: <147039975648.715620.12985971832789032159.stgit@buzz> X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 05 Aug 2016 15:22:36 +0300 Konstantin Khlebnikov wrote: > If module is "module" then dso->short_name is "[module]". > Substring comparing is't enough: "raid10" matches to "[raid1]". > This patch also checks terminating zero in module name. > > Signed-off-by: Konstantin Khlebnikov Looks good to me :) Acked-by: Masami Hiramatsu Thanks! > --- > tools/perf/util/probe-event.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 953dc1ab2ed7..dd2d60ef05d3 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -170,8 +170,10 @@ static struct map *kernel_get_module_map(const char *module) > module = "kernel"; > > for (pos = maps__first(maps); pos; pos = map__next(pos)) { > + /* short_name is "[module]" */ > if (strncmp(pos->dso->short_name + 1, module, > - pos->dso->short_name_len - 2) == 0) { > + pos->dso->short_name_len - 2) == 0 && > + module[pos->dso->short_name_len - 2] == '\0') { > return pos; > } > } > -- Masami Hiramatsu