From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbcHGM4K (ORCPT ); Sun, 7 Aug 2016 08:56:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45586 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751613AbcHGM4J (ORCPT ); Sun, 7 Aug 2016 08:56:09 -0400 Date: Sun, 7 Aug 2016 14:56:04 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Steven Rostedt , Namhyung Kim , Jiri Olsa , lkml , David Ahern , Ingo Molnar , Peter Zijlstra Subject: Re: [RFC 0/4] tools lib traceevent: Install fixes Message-ID: <20160807125604.GA13602@krava> References: <1470073292-18114-1-git-send-email-jolsa@kernel.org> <20160802031055.GB25068@danjae.aot.lge.com> <20160802093134.GB2036@krava> <20160802094823.4a58b42f@gandalf.local.home> <20160802140144.GA18401@krava> <20160805101352.6bc16cdf@gandalf.local.home> <20160805144241.GP14639@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160805144241.GP14639@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Sun, 07 Aug 2016 12:56:08 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2016 at 11:42:41AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 05, 2016 at 10:13:52AM -0400, Steven Rostedt escreveu: > > On Tue, 2 Aug 2016 16:01:44 +0200 > > Jiri Olsa wrote: > > > > BTW, before we start making this ready for their own libraries, I'd > > > > like to make some changes with the naming convention. Mainly with > > > > event_format and format_field. > > > > > > > > Perhaps we should change them to pevent_event and pevent_field? > > > > > > right, it does not have any global prefix for public symbols > > > > > > I'd actualy expect something like 'traceevent_', > > > but 'pevent' is ok as well I guess > > > > OK, what's the consensus here? Should we keep "pevent_" or switch to > > the longer "traceevent_"? > > traceevent_ matches libtraceevent, so I think would be more obvious the > association of code with the library. +1 for traceevent_ ... makes more sense to me jirka