From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752005AbcHGRoG (ORCPT ); Sun, 7 Aug 2016 13:44:06 -0400 Received: from one.firstfloor.org ([193.170.194.197]:50733 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbcHGRoG (ORCPT ); Sun, 7 Aug 2016 13:44:06 -0400 Date: Sun, 7 Aug 2016 10:44:03 -0700 From: Andi Kleen To: Joe Perches Cc: Andi Kleen , Alexey Dobriyan , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk Subject: Re: [PATCH] proc: faster /proc/*/status Message-ID: <20160807174402.GY5871@two.firstfloor.org> References: <20160806125608.GB1187@p183.telecom.by> <87ziop46b8.fsf@tassilo.jf.intel.com> <20160807085322.GB1871@p183.telecom.by> <20160807165947.GX5871@two.firstfloor.org> <1470591565.28648.40.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470591565.28648.40.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > It is so bloated that gcc needs to be asked to not screw up with stack > > > size. > > What happens when you drop all the noinlines for this? I assume > > this would alread make it faster. And now that we have bigger > > stacks we can likely tolerate it. > > %pV recurses through these code paths. > I believe the maximum current recursion depth is 3. I assume 2 max would sufficient for all users in kernel. And perhaps it would be better to get rid of "features" like this, and instead focus on more common cases. -Andi -- ak@linux.intel.com -- Speaking for myself only.