From: Jean Delvare <jdelvare@suse.de>
To: Joe Perches <joe@perches.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] scripts/Lindent: clean up and optimize
Date: Sun, 7 Aug 2016 17:48:49 +0200 [thread overview]
Message-ID: <20160807174849.1e30bef7@endymion> (raw)
In-Reply-To: <1470419599.28648.7.camel@perches.com>
Hi Joe,
On Fri, 05 Aug 2016 10:53:19 -0700, Joe Perches wrote:
> On Fri, 2016-08-05 at 11:26 +0200, Jean Delvare wrote:
> > * Add a few blank lines to improve readability.
> > * Don't call cut 3 times when once is enough.
> > * Drop a useless semicolon.
>
> As it commonly reflows > 80 column code very badly,
> my preference would be to remove Lindent instead.
>
> https://lkml.org/lkml/2013/2/11/390
This was 3.5 years ago, so apparently it's not happening.
Why don't you just remove -l80 from the options, if this is your only
concern with the script? Adding the appropriate option to indent to
support what we think is good would seem even better, but I do not have
any time to devote to this task.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2016-08-07 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 9:26 [PATCH] scripts/Lindent: clean up and optimize Jean Delvare
2016-08-05 17:53 ` Joe Perches
2016-08-07 15:48 ` Jean Delvare [this message]
2016-08-07 16:18 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160807174849.1e30bef7@endymion \
--to=jdelvare@suse.de \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).